Skip to content

Conversation

@akrem-chabchoub
Copy link
Contributor

@akrem-chabchoub akrem-chabchoub commented Oct 29, 2025

Checklist

  • I have read the coding guide.
  • My change requires a documentation update, and I have done it.
  • I have added tests to cover my changes.
  • I have filled out the description and linked the related issues.

Description

Add synctest in subscriber test.

Open API Spec Version Changes (if applicable)

Motivation and Context (Optional)

Related Issue (Optional)

#5232

Screenshots (if appropriate):

@akrem-chabchoub akrem-chabchoub self-assigned this Oct 29, 2025
@akrem-chabchoub akrem-chabchoub added this to the v2.7.0 milestone Oct 29, 2025
@akrem-chabchoub akrem-chabchoub marked this pull request as ready for review October 29, 2025 15:39
Copy link

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR adds testing/synctest support to the event subscriber test to better handle concurrent test scenarios. The main changes focus on wrapping the test logic with synctest.Test() and temporarily narrowing the CI test scope to a specific package.

  • Wrapped the concurrent test logic in synctest.Test() to improve deterministic testing of goroutines and channels
  • Modified Makefile CI targets to temporarily run tests only for the pkg/storer/internal/events package instead of all packages

Reviewed Changes

Copilot reviewed 2 out of 2 changed files in this pull request and generated no comments.

File Description
pkg/storer/internal/events/subscribe_test.go Wrapped test with synctest.Test() to enable deterministic concurrent testing
Makefile Narrowed CI test targets to only test the events package temporarily

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants