Skip to content

i18n: new crowdin translations #1971

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jul 18, 2025
Merged

i18n: new crowdin translations #1971

merged 1 commit into from
Jul 18, 2025

Conversation

github-actions[bot]
Copy link
Contributor

New Crowdin translations from the express.js crowdin project. cc: @expressjs/docs-wg

@github-actions github-actions bot requested a review from a team as a code owner July 11, 2025 22:08
Copy link

netlify bot commented Jul 11, 2025

Deploy Preview for expressjscom-preview ready!

Name Link
🔨 Latest commit 10dda10
🔍 Latest deploy log https://app.netlify.com/projects/expressjscom-preview/deploys/687a52311ea9a0000869348c
😎 Deploy Preview https://deploy-preview-1971--expressjscom-preview.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify project configuration.

@github-actions github-actions bot force-pushed the crowdin/translations branch 3 times, most recently from e906e56 to 151bbe0 Compare July 11, 2025 22:22
@bjohansebas bjohansebas marked this pull request as draft July 11, 2025 22:25
@bjohansebas
Copy link
Member

By the way, I'm testing with Crowdin to solve this automatically.

@github-actions github-actions bot force-pushed the crowdin/translations branch from 151bbe0 to 56c1d34 Compare July 11, 2025 22:47
@bjohansebas
Copy link
Member

I’m contacting Crowdin support to see if they can help me with the integration of the Custom Pre-Export Processor, because so far none of the solutions I’ve tried are working.

@github-actions github-actions bot force-pushed the crowdin/translations branch 3 times, most recently from 59f0518 to c0c1fee Compare July 15, 2025 02:59
@bjohansebas bjohansebas marked this pull request as ready for review July 16, 2025 18:20
Copy link
Member

@bjohansebas bjohansebas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Blocked until this is merged

@bjohansebas bjohansebas added the blocked PRs that are blocked by other issues or PRs label Jul 16, 2025
@github-actions github-actions bot force-pushed the crowdin/translations branch from c0c1fee to 5329e90 Compare July 18, 2025 13:47
@ShubhamOulkar ShubhamOulkar removed the blocked PRs that are blocked by other issues or PRs label Jul 18, 2025
@github-actions github-actions bot force-pushed the crowdin/translations branch from 5329e90 to 9dae0f1 Compare July 18, 2025 13:51
@github-actions github-actions bot force-pushed the crowdin/translations branch from 9dae0f1 to 10dda10 Compare July 18, 2025 13:54
@bjohansebas bjohansebas requested a review from Copilot July 18, 2025 13:58
Copy link
Contributor

@Copilot Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR updates the Express.js documentation with new Crowdin translations from the internationalization project, primarily focusing on Korean, Spanish, and Chinese translations with additional updates across multiple language files.

  • Adds table scrolling wrapper to multiple language versions for better mobile/responsive display
  • Translates extensive Korean documentation including error handling, security best practices, and API references
  • Updates Spanish homepage content and translations
  • Includes Chinese translation improvements and navigation menu updates

Reviewed Changes

Copilot reviewed 24 out of 24 changed files in this pull request and generated 8 comments.

Show a summary per file
File Description
zh-tw/guide/writing-middleware.md Adds table-scroller wrapper for responsive table display
zh-cn/guide/writing-middleware.md Adds table-scroller wrapper for responsive table display
pt-br/guide/writing-middleware.md Adds table-scroller wrapper for responsive table display
ko/guide/writing-middleware.md Adds table-scroller wrapper for responsive table display
ko/guide/error-handling.md Comprehensive Korean translation of error handling documentation
ko/guide/behind-proxies.md Korean translation of proxy configuration guide
ko/changelog/index.md Korean translation of changelog navigation and release notes
ko/advanced/security-updates.md Korean translation of security updates documentation
ko/advanced/healthcheck-graceful-shutdown.md Korean translation of health check and graceful shutdown guide
ko/advanced/developing-template-engines.md Korean translation updates for template engine development
ko/advanced/best-practice-security.md Korean translation of security best practices
ko/advanced/best-practice-performance.md Korean translation of performance best practices
ko/5x/api.md Korean translation of Express 5.x API reference
ko/4x/api.md Korean translation of Express 4.x API reference
ko/3x/api.md Korean translation of Express 3.x API reference
ja/guide/writing-middleware.md Adds table-scroller wrapper for responsive table display
it/guide/writing-middleware.md Adds table-scroller wrapper for responsive table display
fr/guide/writing-middleware.md Adds table-scroller wrapper for responsive table display
es/index.md Spanish translation of homepage content and navigation
es/guide/writing-middleware.md Adds table-scroller wrapper for responsive table display
es/api.md Spanish translation of API reference description
de/guide/writing-middleware.md Adds table-scroller wrapper for responsive table display
_data/ko/menu.yml Korean translation of menu navigation items
_data/es/general.yml Spanish translation of general UI text and announcements


Use promises to avoid the overhead of the `try...catch` block or when using functions
that return promises. 예를 들면 다음과 같습니다.
프로미스를 사용하면 `try...catch` 블록의 오버헤드를 피하거나 프로미스를 반환하는 함수를 사용할 때 유용합니다. 예를 들면 다음과 같습니다. 예를 들면 다음과 같습니다.
Copy link
Preview

Copilot AI Jul 18, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The phrase "예를 들면 다음과 같습니다" is duplicated at the end of the sentence. One instance should be removed.

Suggested change
프로미스를 사용하면 `try...catch` 블록의 오버헤드를 피하거나 프로미스를 반환하는 함수를 사용할 때 유용합니다. 예를 들면 다음과 같습니다. 예를 들면 다음과 같습니다.
프로미스를 사용하면 `try...catch` 블록의 오버헤드를 피하거나 프로미스를 반환하는 함수를 사용할 때 유용합니다. 예를 들면 다음과 같습니다.

Copilot uses AI. Check for mistakes.

@@ -109,7 +109,8 @@ app.get('/search', (req, res) => {

#### 프로미스 사용

When an error is thrown in an `async` function or a rejected promise is awaited inside an `async` function, those errors will be passed to the error handler as if calling `next(err)`
async 함수 내에서 에러가 발생하거나, async 함수 안에서 거부된(rejected) 프로미스를 await 할 경우, 해당 에러는`next(err)`를 호출한 것과 동일하게 에러 핸들러로 전달됩니다.
Copy link
Preview

Copilot AI Jul 18, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Missing space before the backtick in "next(err)". Should be "에러는 next(err)를".

Suggested change
async 함수 내에서 에러가 발생하거나, async 함수 안에서 거부된(rejected) 프로미스를 await 할 경우, 해당 에러는`next(err)`를 호출한 것과 동일하게 에러 핸들러로 전달됩니다.
async 함수 내에서 에러가 발생하거나, async 함수 안에서 거부된(rejected) 프로미스를 await 할 경우, 해당 에러는 `next(err)`를 호출한 것과 동일하게 에러 핸들러로 전달됩니다.

Copilot uses AI. Check for mistakes.

<li>
{{ readme | markdownify }}
</li>
<h3 id="sidebar-heading" class="toc-heading"><button id="menu-toggle" title="show express versions">버전</button></h3><0>버전<1>►</1></0> <ul id="menu">
Copy link
Preview

Copilot AI Jul 18, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The HTML structure appears corrupted with unusual tag elements "<0>" and "<1>". This should be cleaned up to maintain proper HTML structure.

Suggested change
<h3 id="sidebar-heading" class="toc-heading"><button id="menu-toggle" title="show express versions">버전</button></h3><0>버전<1>►</1></0> <ul id="menu">
<h3 id="sidebar-heading" class="toc-heading"><button id="menu-toggle" title="show express versions">버전</button></h3>버전 ► <ul id="menu">

Copilot uses AI. Check for mistakes.

@@ -27,7 +27,7 @@ process.on('SIGTERM', () => {

## Health checks

A load balancer uses health checks to determine if an application instance is healthy and can accept requests. For example, [Kubernetes has two health checks](https://kubernetes.io/docs/tasks/configure-pod-container/configure-liveness-readiness-probes/):
로드 밸런서는 헬스 체크를 통해 애플리케이션 인스턴스가 정상적으로 작동 중이며 요청을 수락할 수 있는지 판단합니다. For example, [Kubernetes has two health checks](https://kubernetes.io/docs/tasks/configure-pod-container/configure-liveness-readiness-probes/):
Copy link
Preview

Copilot AI Jul 18, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The sentence contains both Korean and English text. The English part "For example, [Kubernetes has two health checks]" should be translated to Korean for consistency.

Suggested change
로드 밸런서는 헬스 체크를 통해 애플리케이션 인스턴스가 정상적으로 작동 중이며 요청을 수락할 수 있는지 판단합니다. For example, [Kubernetes has two health checks](https://kubernetes.io/docs/tasks/configure-pod-container/configure-liveness-readiness-probes/):
로드 밸런서는 헬스 체크를 통해 애플리케이션 인스턴스가 정상적으로 작동 중이며 요청을 수락할 수 있는지 판단합니다. 예를 들어, [Kubernetes에는 두 가지 헬스 체크](https://kubernetes.io/docs/tasks/configure-pod-container/configure-liveness-readiness-probes/)가 있습니다:

Copilot uses AI. Check for mistakes.


1. The number of consecutive failed attempts by the same user name and IP address.
2. The number of failed attempts from an IP address over some long period of time. For example, block an IP address if it makes 100 failed attempts in one day.
1. .
Copy link
Preview

Copilot AI Jul 18, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The numbered list item is incomplete, containing only a period. The content appears to be missing.

Suggested change
1. .
1. 사용자 계정에 대한 연속된 실패 시도 횟수입니다. 예를 들어, 5번의 연속된 실패 시도가 발생하면 계정을 일시적으로 잠글 수 있습니다.

Copilot uses AI. Check for mistakes.


NODE_ENV를 "production"으로 설정하면 Express는 다음과 같이 동작합니다.

- 보기 템플리트를 캐싱.
- CSS 확장기능을 통해 생성된 CSS 파일을 캐싱.
- 더 간결한 오류 메시지를 생성.

[Tests indicate](https://www.dynatrace.com/news/blog/the-drastic-effects-of-omitting-node-env-in-your-express-js-applications/) that just doing this can improve app performance by a factor of three!
[테스트 결과에 따르면]((https://www.dynatrace.com/news/blog/the-drastic-effects-of-omitting-node-env-in-your-express-js-applications/) NODE_ENV를 production으로 설정하는 것만으로도 애플리케이션 성능이 3배 향상될 수 있음이 확인되었습니다.
Copy link
Preview

Copilot AI Jul 18, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There are double opening parentheses in the link: "[[테스트 결과에 따르면]((". Should be "[테스트 결과에 따르면](". Also, the closing parenthesis is missing for the link.

Suggested change
[테스트 결과에 따르면]((https://www.dynatrace.com/news/blog/the-drastic-effects-of-omitting-node-env-in-your-express-js-applications/) NODE_ENV를 production으로 설정하는 것만으로도 애플리케이션 성능이 3배 향상될 수 있음이 확인되었습니다.
[테스트 결과에 따르면](https://www.dynatrace.com/news/blog/the-drastic-effects-of-omitting-node-env-in-your-express-js-applications/) NODE_ENV를 production으로 설정하는 것만으로도 애플리케이션 성능이 3배 향상될 수 있음이 확인되었습니다.

Copilot uses AI. Check for mistakes.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

we missed this suggestion😊

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This has to be done from Crowdin, if you want, you can change it from there.

@bjohansebas bjohansebas merged commit 35b4b3b into gh-pages Jul 18, 2025
12 checks passed
@bjohansebas bjohansebas deleted the crowdin/translations branch July 18, 2025 14:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants