codeql: add query to check for wrong pool ele_acquire null check #7056
+77
−27
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Performance Measurements ⏳
|
pool ele_acquire can never return NULL (even when the pool is empty) so checking for that is likely to be a misunderstanding or superflous.
intrigus-lgtm
force-pushed
the
intrigus/feat/codeql-fd_pool_acquire-ub
branch
from
4e532e1 to
6bbb04d
Compare
Performance Measurements ⏳
|
two-heart
approved these changes
Nov 6, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
pool ele_acquire can never return NULL (even when the pool is empty) so checking for that is likely to be a misunderstanding or superflous.