sourcev1: align CRD validation with v1beta2 #1944
Open
+4
−0
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
|
Setting defaults for optional values will cause drift and etcd mutation, also all the CLI tests will fail as we don't expect for optional values to come back from etcd if they are not in the desired state. |
Author
|
Thanks Stefan! I am on it! |
kthurman59
force-pushed
the
feature/crd-validation-source-v1
branch
from
1a445f9 to
f2508bd
Compare
Author
|
Thanks for the feedback. I’ve removed the defaults from the optional fields in GitRepository and HelmRepository and regenerated the CRDs, so this PR now only adds the HelmChart XValidation. Testing:
|
kthurman59
force-pushed
the
feature/crd-validation-source-v1
branch
from
f2508bd to
1d52fa7
Compare
Author
|
I also fixed the missing DCO signing for my commits. |
Member
|
Also squash please 🙏 |
Signed-off-by: kthurman59 <[email protected]>
kthurman59
force-pushed
the
feature/crd-validation-source-v1
branch
from
1d52fa7 to
4646ca6
Compare
Author
|
Squashed!! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Align source.toolkit.fluxcd.io/v1 CRD validation with the existing v1beta2 behavior and documentation.
Changes
HelmChart
No controller logic changes, only schema-level validation so invalid specs fail at admission instead of at reconciliation.
Testing
On an Ubuntu VM: