Skip to content

sourcev1: align CRD validation with v1beta2 #1944

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
+4 −0
Open

sourcev1: align CRD validation with v1beta2 #1944

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions api/v1/helmchart_types.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -28,6 +28,7 @@ import (
const HelmChartKind = "HelmChart"

// HelmChartSpec specifies the desired state of a Helm chart.
// +kubebuilder:validation:XValidation:rule="!has(self.verify) || self.sourceRef.kind == 'HelmRepository'",message="spec.verify is only supported when spec.sourceRef.kind is 'HelmRepository'"
type HelmChartSpec struct {
// Chart is the name or path the Helm chart is available at in the
// SourceRef.
Expand Down
3 changes: 3 additions & 0 deletions config/crd/bases/source.toolkit.fluxcd.io_helmcharts.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -198,6 +198,9 @@ spec:
- interval
- sourceRef
type: object
x-kubernetes-validations:
- message: spec.verify is only supported when spec.sourceRef.kind is 'HelmRepository'
rule: '!has(self.verify) || self.sourceRef.kind == ''HelmRepository'''
status:
default:
observedGeneration: -1
Expand Down