Fix gas tests #3421
Closed
Fix gas tests #3421
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced May 28, 2025
Closed
Closed
cptartur
force-pushed
the
spr/master/5e47ad12
branch
from
9747f50 to
d153a5a
Compare
cptartur
force-pushed
the
spr/master/5e47ad12
branch
3 times, most recently
from
d5cda9e to
1a62be9
Compare
cptartur
force-pushed
the
spr/master/3ae67c8b
branch
from
f38dfe6 to
18ca365
Compare
cptartur
force-pushed
the
spr/master/5e47ad12
branch
from
1a62be9 to
0229119
Compare
cptartur
force-pushed
the
spr/master/5e47ad12
branch
2 times, most recently
from
e7643c3 to
75c18b8
Compare
cptartur
force-pushed
the
spr/master/3ae67c8b
branch
2 times, most recently
from
74a169a to
5d32ffb
Compare
cptartur
force-pushed
the
spr/master/5e47ad12
branch
from
75c18b8 to
2ba83a2
Compare
cptartur
force-pushed
the
spr/master/3ae67c8b
branch
from
5d32ffb to
eb889c1
Compare
cptartur
force-pushed
the
spr/master/5e47ad12
branch
3 times, most recently
from
4182e0e to
ea3b359
Compare
cptartur
force-pushed
the
spr/master/3ae67c8b
branch
from
13de164 to
b45b9d5
Compare
This was referenced Jun 13, 2025
cptartur
force-pushed
the
spr/master/3ae67c8b
branch
from
b45b9d5 to
ab22024
Compare
cptartur
force-pushed
the
spr/master/5e47ad12
branch
from
ea3b359 to
b0ef916
Compare
This was referenced Jun 27, 2025
cptartur
force-pushed
the
spr/master/3ae67c8b
branch
from
a05acbb to
94149fd
Compare
cptartur
force-pushed
the
spr/master/5e47ad12
branch
from
3d7c575 to
5ef07eb
Compare
cptartur
force-pushed
the
spr/master/5e47ad12
branch
2 times, most recently
from
74e5dfb to
cf71b49
Compare
cptartur
force-pushed
the
spr/master/3ae67c8b
branch
2 times, most recently
from
0d0d139 to
a0f20c1
Compare
cptartur
force-pushed
the
spr/master/5e47ad12
branch
from
cf71b49 to
52de983
Compare
cptartur
force-pushed
the
spr/master/3ae67c8b
branch
from
a0f20c1 to
18a799d
Compare
cptartur
force-pushed
the
spr/master/5e47ad12
branch
from
52de983 to
660befc
Compare
ddoktorski
reviewed
Jul 18, 2025
| // 96 = cost of deploy (see snforge_std_deploy_cost test) | ||
| // 9 = cost of 202 range check builtins (because int(0.04 * 202) = 9) | ||
| // 0 l1_gas + 96 l1_data_gas + 9 * (100 / 0.0025) l2 gas | ||
| // 9 = cost of 202 range check builtins (because int(0.04 * 245) = 10) |
There was a problem hiding this comment.
Suggested change
| // 9 = cost of 202 range check builtins (because int(0.04 * 245) = 10) | |
| // 10 = cost of 245 range check builtins (because int(0.04 * 245) = 10) |
Why is it 245?
There was a problem hiding this comment.
Had to change the range_check test (see file above) and happened to add too many lines 😅
cptartur
force-pushed
the
spr/master/5e47ad12
branch
2 times, most recently
from
8a340f4 to
b185ce6
Compare
cptartur
force-pushed
the
spr/master/3ae67c8b
branch
from
7cd7a3f to
7c4845c
Compare
cptartur
force-pushed
the
spr/master/5e47ad12
branch
from
b185ce6 to
458b46c
Compare
cptartur
force-pushed
the
spr/master/3ae67c8b
branch
from
7c4845c to
9c31241
Compare
cptartur
force-pushed
the
spr/master/5e47ad12
branch
2 times, most recently
from
7a2a8a0 to
9b02743
Compare
cptartur
force-pushed
the
spr/master/3ae67c8b
branch
2 times, most recently
from
72b2615 to
83a2477
Compare
Merged
cptartur
force-pushed
the
spr/master/5e47ad12
branch
from
9b02743 to
3766b57
Compare
Closes #3078 commit-id:5e47ad12 # Conflicts: # crates/forge/tests/integration/gas.rs # Conflicts: # crates/forge/tests/integration/gas.rs
cptartur
force-pushed
the
spr/master/3ae67c8b
branch
from
83a2477 to
d60a75b
Compare
cptartur
force-pushed
the
spr/master/5e47ad12
branch
from
3766b57 to
8e48940
Compare
|
✓ Commit merged in pull request #3559 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #3078
Stack:
supports-panic-backtracetest condition #3503_stdpackages #3470snforge_stdorsnforge_std_compatibilityinsnforgenew #3466_compatibilityplugin #3465_compatibilitypackage #3464scarbfmt#3419