Bump deps, use scarb in nightly

[cptartur]

Stack:

• Macros V2 #3573
• Add v2 macros migration guide #3559
• Bump deps, use scarb in nightly #3553 ⬅
• Remove supports-panic-backtrace test condition #3503
• Run tests on a new and compatibility plugin #3502
• Runtime checks for _std packages #3470
• Use snforge_std or snforge_std_compatibility in snforge new #3466
• Update release workflows to publish _compatibility plugin #3465
• Add _compatibility package #3464
• Add tests for diagnostics #3424
• Fix gas tests #3421
• Disable scarb 2.10.0 specific tests #3420
• Run scarbfmt #3419
• Migrate to new macro syntax #3415

⚠️ Part of a stack created by spr. Do not merge manually using the UI - doing so may have unexpected results.

[kkawula]

github.event_name == 'workflow_dispatch'
this line is responsible for publishing plugin manually
As you can see, the only way to trigger _publish-plugin.yml is workflow_call, but there is no such event_name as workflow_call, event_name is always inherited from calling workflow, in that scenerio it will be always, workflow_dispatch from publish-plugin.yml, that can be triggered only in that way

starknet-foundry/.github/workflows/publish-plugin.yml

Line 4 in 52ff01d

workflow_dispatch:

[cptartur]

Right, but even in case of manually running a workflow, we should still check if the plugin was not published already. Because if it was, the workflow will just fail, unless that was the intended behavior?

The problem is, _publish-plugin workflow is also reused in nightly workflow which is also triggered manually. If any step of nightly workflow fails after uploading plugins, then due to this line, you cannot re-run it because on subsequent runs it will fail as it will try to upload plugin again (which registry doesn't allow).

[cptartur]

✓ Commit merged in pull request #3559