feat(issues): Fallback to case insensitive short id lookup #102103
+56
−1
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
We allowed people to create projects with case insensitive slugs a while ago, its tricky to update them to not be case sensitive. Adds a fallback lookup to case insensitive project slug
github-actions
bot
added
the
Scope: Backend
![cursor[bot]](https://avatars.githubusercontent.com/in/1210556?s=60&v=4){kind=small}
src/sentry/models/group.py
Outdated
| Q(project__slug__iexact=slug, short_id__in=short_ids) | ||
| for slug, short_ids in project_short_id_lookup.items() | ||
| ], | ||
| ) |
There was a problem hiding this comment.
Bug: Unused Variable Causes Redundant Database Queries
The missing_short_ids variable is computed but not used when constructing the fallback query. This causes the case-insensitive lookup to re-query for short IDs that were already found in the initial exact-match query, leading to inefficient database operations.
cvxluo
reviewed
Oct 24, 2025
Comment on lines
379
to
381
| for sid in short_ids: | ||
| if sid.short_id in missing_short_ids: | ||
| missing_by_slug[sid.project_slug].append(sid.short_id) |
There was a problem hiding this comment.
i think you hold all the missing short ids already in missing_short_ids?
Suggested change
| for sid in short_ids: | |
| if sid.short_id in missing_short_ids: | |
| missing_by_slug[sid.project_slug].append(sid.short_id) | |
| for missing_short_id in missing_short_ids | |
| missing_by_slug[short_id.project_slug].append(short_id.short_id) |
src/sentry/models/group.py
Outdated
Comment on lines
403
to
405
| existing_ids = {g.id for g in groups} | ||
| groups.extend(g for g in fallback_groups if g.id not in existing_ids) | ||
| group_lookup = {group.short_id for group in groups} |
There was a problem hiding this comment.
isn't there guaranteed no overlap between fallback_groups and groups? do we need the additional check?
Suggested change
| existing_ids = {g.id for g in groups} | |
| groups.extend(g for g in fallback_groups if g.id not in existing_ids) | |
| group_lookup = {group.short_id for group in groups} | |
| groups.extend(g for g in fallback_groups) | |
| group_lookup = {group.short_id for group in groups} |
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #102103 +/- ##
========================================
Coverage 80.95% 80.96%
========================================
Files 8743 8742 -1
Lines 389054 389022 -32
Branches 24693 24685 -8
========================================
+ Hits 314972 314974 +2
+ Misses 73727 73693 -34
Partials 355 355 |
cvxluo
approved these changes
Oct 26, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We allowed people to create projects with case insensitive slugs a while ago, its tricky to update them to not be case sensitive.
Adds a fallback lookup to case insensitive project slug. Fixes an issue where the errors dataset could not query by issue short id when the project contained uppercase letters.
issue:PROJECTSLUG-E123Redash query with number of project slugs that contain case insensitive characters
Redash query of projects with insensitive characters with recent issues