-
-
Notifications
You must be signed in to change notification settings - Fork 4.5k
feat(issues): Fallback to case insensitive short id lookup #102103
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
scttcper
merged 7 commits into
master
from
scttcper/allow-lowercase-by_qualified_short_id_bulk
Oct 28, 2025
Merged
Changes from 1 commit
Commits
Show all changes
7 commits
Select commit
Hold shift + click to select a range
1000193
feat(issues): Fallback to case insensitive short id lookup
scttcper 0dc83da
only lookup the missing ones
scttcper 01794e9
Merge branch 'master' into scttcper/allow-lowercase-by_qualified_shor…
scttcper 4e2eae2
add feature flag and other feedback
scttcper 5d40143
in fallback_groups
scttcper 3b26d7d
add feature to test
scttcper 8dc0199
add base queryset
scttcper File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Some comments aren't visible on the classic Files Changed page.
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change | ||||||||||
|---|---|---|---|---|---|---|---|---|---|---|---|---|
|
|
@@ -369,6 +369,35 @@ def by_qualified_short_id_bulk( | |||||||||||
| ).filter(short_id_lookup, project__organization=organization_id) | ||||||||||||
| ) | ||||||||||||
| group_lookup: set[int] = {group.short_id for group in groups} | ||||||||||||
|
|
||||||||||||
| # If any requested short_ids are missing after the exact slug match, | ||||||||||||
| # fallback to a case-insensitive slug lookup to handle legacy/mixed-case slugs. | ||||||||||||
| missing_short_ids = [sid.short_id for sid in short_ids if sid.short_id not in group_lookup] | ||||||||||||
| if missing_short_ids: | ||||||||||||
| ci_short_id_lookup = reduce( | ||||||||||||
| or_, | ||||||||||||
| [ | ||||||||||||
| Q(project__slug__iexact=slug, short_id__in=short_ids) | ||||||||||||
| for slug, short_ids in project_short_id_lookup.items() | ||||||||||||
| ], | ||||||||||||
| ) | ||||||||||||
|
|
||||||||||||
| fallback_groups = list( | ||||||||||||
| self.exclude( | ||||||||||||
| status__in=[ | ||||||||||||
| GroupStatus.PENDING_DELETION, | ||||||||||||
| GroupStatus.DELETION_IN_PROGRESS, | ||||||||||||
| GroupStatus.PENDING_MERGE, | ||||||||||||
| ] | ||||||||||||
| ).filter(ci_short_id_lookup, project__organization=organization_id) | ||||||||||||
| ) | ||||||||||||
|
|
||||||||||||
| if fallback_groups: | ||||||||||||
| # Merge unique groups from fallback | ||||||||||||
| existing_ids = {g.id for g in groups} | ||||||||||||
| groups.extend(g for g in fallback_groups if g.id not in existing_ids) | ||||||||||||
| group_lookup = {group.short_id for group in groups} | ||||||||||||
|
||||||||||||
| existing_ids = {g.id for g in groups} | |
| groups.extend(g for g in fallback_groups if g.id not in existing_ids) | |
| group_lookup = {group.short_id for group in groups} | |
| groups.extend(g for g in fallback_groups) | |
| group_lookup = {group.short_id for group in groups} |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Bug: Unused Variable Causes Redundant Database Queries
The
missing_short_idsvariable is computed but not used when constructing the fallback query. This causes the case-insensitive lookup to re-query for short IDs that were already found in the initial exact-match query, leading to inefficient database operations.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
twist my arm