CANN: Add ggml_set_rows #14943
Merged
CANN: Add ggml_set_rows #14943
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
ggml
ggerganov
approved these changes
Jul 29, 2025
Add ggml_set_rows for F32 and F16. ggml-org#14274 ggml-org#14661
|
Due to lack of ACL operator support, currently only float and float16 data types are supported. Support for other data types will be added once the operators are available. Performance verification on Qwen2.5-7B FP16 shows a 3% improvement. |
|
Great contribution! Thank you for the code refactoring and the addition of the |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add ggml_set_rows for F32 and F16. #14274 #14661
Make sure to read the contributing guidelines before submitting a PR