Go: Make diagnostics unit-testable and add test for EmitCannotFindPackages
#21214
+177
−40
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mbg
force-pushed
the
mbg/go/improve-package-not-found
branch
from
7e91ac5 to
f837d90
Compare
Contributor
There was a problem hiding this comment.
Pull request overview
This PR makes the Go extractor diagnostics output mechanism injectable to enable unit testing, and adds unit tests for the go/autobuilder/package-not-found diagnostic emitted by EmitCannotFindPackages.
Changes:
- Introduce a
DiagnosticsWriterabstraction and a file-backed default writer for diagnostics emission. - Update the extractor to call
EmitCannotFindPackageswith an explicit writer. - Add unit tests for
EmitCannotFindPackagesand wire them into Bazel.
Reviewed changes
Copilot reviewed 9 out of 10 changed files in this pull request and generated 3 comments.
Show a summary per file
| File | Description |
|---|---|
| go/extractor/diagnostics/diagnostics.go | Adds DiagnosticsWriter + file writer and routes EmitCannotFindPackages through an injected writer. |
| go/extractor/extractor.go | Updates call site to pass diagnostics.DefaultWriter into EmitCannotFindPackages. |
| go/extractor/diagnostics/diagnostics_test.go | Adds unit tests covering default/dynamic/actions messaging variants. |
| go/extractor/diagnostics/BUILD.bazel | Adds a go_test target for the new unit tests. |
| go/extractor/go.mod | Adds new module deps needed for tests (testify + transitive deps). |
| go/extractor/go.sum | Updates dependency checksums accordingly. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
mbg
force-pushed
the
mbg/go/diagnostics-unit-tests
branch
from
f262616 to
1fba381
Compare
mbg
force-pushed
the
mbg/go/diagnostics-unit-tests
branch
from
1fba381 to
45e0a92
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Mostly a follow-up from (and based on) #21213 which:
diagnostics.gomore easily testable by abstracting over the diagnostics output mechanism.EmitCannotFindPackages