form performance, better solution for computeDynamicInputSize

[orthagh]

Description

• Related to Slow performance and crashes when managing the form - glpi 11-rc1 #20416 (not a final fix, @ccailly is working on another part)
• Replace the creation of a virtual element by a direct usage of ch unit (1 char width)

[AdrienClairembault]

Did you check with lot of small (l) and wide (m) letters?
As far as I remember, this solution do not work with non mono-spaced fonts.

[orthagh]

this solution do not work with non mono-spaced fonts.

You are completely right.
I made the PR between 2 meetings, but I was not entirely satisfied with the result. It works, but there may be issues with language using non-Latin alphabets.
I think I'll remove everything and let the field using 100% of the space, it will be safer

[AdrienClairembault]

Just a side note, if you set the field to full width then the * marker for required questions might look out of place as it wont be next to the question name (this was the reason for this feature).

Maybe it should be removed too in this case?

[orthagh]

It's ok imo

[trasher]

@orthagh any reason this one is still a draft?

[orthagh]

None, apart I didn't pay attention

[cedric-anne]

@orthagh any reason this one is still a draft?

@AdrienClairembault says me to not merge it.

[trasher]

@orthagh any reason this one is still a draft?

@AdrienClairembault says me to not merge it.

OK... So I let you close/whatever.

[cedric-anne]

Included in #21179.