Skip to content

Conversation

ccailly
Copy link
Member

@ccailly ccailly commented Sep 29, 2025

Checklist before requesting a review

Please delete options that are not relevant.

  • I have read the CONTRIBUTING document.
  • I have performed a self-review of my code.
  • I have added tests that prove my fix is effective or that my feature works.
  • This change requires a documentation update.

Description

@AdrienClairembault
Copy link
Contributor

Prevent duplicated SQL queries for condition data

For our biggest "garbage dump" test form:

  • SQL queries down to 19 (from 1000+).
  • Response time down to 1.2s (from 2s).

@orthagh orthagh changed the title Fix/form editor tinymce performances Fix/form editor performances Sep 29, 2025
@cconard96
Copy link
Contributor

Not sure it is related, but getting the tinyMCE toolbar takes two clicks in a form question in the editor.

Overall, performance in the editor seems better.

The performance issue I noticed in the translations tab doesn't seem addressed here. Every tinyMCE editor for each language modal is initialized immediately and the time it takes the server to render the form_translations template is still quite long. So, there is a server and client performance issue there.

@AdrienClairembault AdrienClairembault marked this pull request as ready for review September 30, 2025 11:56
@trasher
Copy link
Contributor

trasher commented Sep 30, 2025

There are a lot of fails in e2e tests

@cedric-anne cedric-anne changed the title Fix/form editor performances Fix form editor performances Sep 30, 2025
@cedric-anne cedric-anne merged commit 00cda7a into glpi-project:11.0/bugfixes Sep 30, 2025
7 of 10 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants