Skip to content

feat: support multi-line selection with URL parameters #35210

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 3 commits into
base: main
Choose a base branch
from
Open

feat: support multi-line selection with URL parameters #35210

wants to merge 3 commits into from

Conversation

kerwin612
Copy link
Member

image

@GiteaBot GiteaBot added the lgtm/need 2 This PR needs two approvals by maintainers to be considered for merging. label Aug 4, 2025
@github-actions github-actions bot added modifies/templates This PR modifies the template files modifies/frontend labels Aug 4, 2025
silverwind
silverwind reviewed Aug 4, 2025
View reviewed changes
silverwind
silverwind reviewed Aug 4, 2025
View reviewed changes
kerwin612 and others added 2 commits August 4, 2025 21:22
@kerwin612 @silverwind
Update web_src/js/features/repo-code.ts
d7ccf38 
Co-authored-by: silverwind <[email protected]>
Signed-off-by: Kerwin Bryant <[email protected]>
@kerwin612 @silverwind
Update web_src/js/features/repo-code.ts
c63f1d2 
Co-authored-by: silverwind <[email protected]>
Signed-off-by: Kerwin Bryant <[email protected]>
@GiteaBot GiteaBot added lgtm/need 1 This PR needs approval from one additional maintainer to be merged. and removed lgtm/need 2 This PR needs two approvals by maintainers to be considered for merging. labels Aug 4, 2025
@GiteaBot GiteaBot added lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. and removed lgtm/need 1 This PR needs approval from one additional maintainer to be merged. labels Aug 5, 2025
@lunny lunny added this to the 1.25.0 milestone Aug 5, 2025
wxiaoguang
wxiaoguang requested changes Aug 5, 2025
View reviewed changes
Copy link
Contributor

@wxiaoguang wxiaoguang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think other pages are broken.

Image

@GiteaBot GiteaBot added lgtm/blocked A maintainer has reservations with the PR and thus it cannot be merged and removed lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. labels Aug 5, 2025
wxiaoguang
wxiaoguang reviewed Aug 5, 2025
View reviewed changes
web_src/js/features/repo-code.ts
@@ -96,16 +97,27 @@ function showLineButton() {

createTippy(btn, {
theme: 'menu',
trigger: 'click',
hideOnClick: true,
trigger: 'manual', // Use manual trigger
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why it needs to use "manual"? It causes other bugs like "the menu won't be hidden when click on document".

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@silverwind silverwind silverwind left review comments

@wxiaoguang wxiaoguang wxiaoguang requested changes

@appleboy appleboy appleboy approved these changes

@lunny lunny lunny approved these changes

Assignees
No one assigned
Labels
lgtm/blocked A maintainer has reservations with the PR and thus it cannot be merged modifies/frontend modifies/templates This PR modifies the template files
Projects
None yet
Milestone
1.25.0
Development

Successfully merging this pull request may close these issues.
6 participants
@kerwin612 @appleboy @lunny @silverwind @wxiaoguang @GiteaBot