Skip to content

feat: support multi-line selection with URL parameters #35210

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 3 commits into
base: main
Choose a base branch
from
Open

feat: support multi-line selection with URL parameters #35210

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
32b4725
feat: support multi-line selection with URL parameters
kerwin612 Aug 4, 2025
d7ccf38
Update web_src/js/features/repo-code.ts
kerwin612 Aug 4, 2025
c63f1d2
Update web_src/js/features/repo-code.ts
kerwin612 Aug 4, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion templates/repo/view_file.tmpl
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -108,7 +108,7 @@
{{range $idx, $code := .FileContent}}
{{$line := Eval $idx "+" 1}}
<tr>
<td id="L{{$line}}" class="lines-num"><span id="L{{$line}}" data-line-number="{{$line}}"></span></td>
<td id="L{{$line}}" class="lines-num"><span data-line-number="{{$line}}"></span></td>
{{if $.EscapeStatus.Escaped}}
<td class="lines-escape">{{if (index $.LineEscapeStatus $idx).Escaped}}<button class="toggle-escape-button btn interact-bg" title="{{if (index $.LineEscapeStatus $idx).HasInvisible}}{{ctx.Locale.Tr "repo.invisible_runes_line"}} {{end}}{{if (index $.LineEscapeStatus $idx).HasAmbiguous}}{{ctx.Locale.Tr "repo.ambiguous_runes_line"}}{{end}}"></button>{{end}}</td>
{{end}}
Expand Down
38 changes: 25 additions & 13 deletions web_src/js/features/repo-code.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -14,7 +14,7 @@ function changeHash(hash: string) {
// it selects the code lines defined by range: `L1-L3` (3 lines) or `L2` (singe line)
function selectRange(range: string): Element {
for (const el of document.querySelectorAll('.code-view tr.active')) el.classList.remove('active');
const elLineNums = document.querySelectorAll(`.code-view td.lines-num span[data-line-number]`);
const elLineNums = document.querySelectorAll(`.code-view td.lines-num[id^="L"]`);

const refInNewIssue = document.querySelector('a.ref-in-new-issue');
const copyPermalink = document.querySelector('a.copy-line-permalink');
Expand Down Expand Up @@ -81,11 +81,12 @@ function showLineButton() {
el.remove();
}

// find active row and add button
const tr = document.querySelector('.code-view tr.active');
if (!tr) return;
// Find first active row and add button
const activeRows = document.querySelectorAll('.code-view tr.active');
if (activeRows.length === 0) return;

const td = tr.querySelector('td.lines-num');
const firstActiveRow = activeRows[0];
const td = firstActiveRow.querySelector('td.lines-num');
const btn = document.createElement('button');
btn.classList.add('code-line-button', 'ui', 'basic', 'button');
btn.innerHTML = svg('octicon-kebab-horizontal');
Expand All @@ -96,16 +97,27 @@ function showLineButton() {

createTippy(btn, {
theme: 'menu',
trigger: 'click',
hideOnClick: true,
trigger: 'manual', // Use manual trigger
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why it needs to use "manual"? It causes other bugs like "the menu won't be hidden when click on document".

content: menu,
placement: 'right-start',
interactive: true,
onShow: (tippy) => {
tippy.popper.addEventListener('click', () => {
tippy.hide();
}, {once: true});
},
appendTo: () => document.body,
});

// Handle menu button click manually
btn.addEventListener('click', (e) => {
e.stopPropagation();
const tippyInstance = btn._tippy;
if (tippyInstance?.state.isVisible) {
tippyInstance.hide();
} else if (tippyInstance) {
tippyInstance.show();
}
});

// Hide menu when clicking menu items
menu.addEventListener('click', () => {
btn._tippy?.hide();
});
}

Expand All @@ -118,7 +130,7 @@ export function initRepoCodeView() {

// "file code view" and "blame" pages need this "line number button" feature
let selRangeStart: string;
addDelegatedEventListener(document, 'click', '.code-view .lines-num span', (el: HTMLElement, e: KeyboardEvent) => {
addDelegatedEventListener(document, 'click', '.code-view .lines-num', (el: HTMLElement, e: KeyboardEvent) => {
if (!selRangeStart || !e.shiftKey) {
selRangeStart = el.getAttribute('id');
selectRange(selRangeStart);
Expand Down