Fix dependencies in xls/public #3121
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hzeller
commented
Sep 26, 2025
| #include "xls/public/c_api_dslx.h" | ||
| #include "xls/public/c_api_format_preference.h" | ||
| #include "xls/public/c_api_ir_builder.h" | ||
| #include "xls/public/c_api_vast.h" |
There was a problem hiding this comment.
Here I am unsure; nothing in the header needs this, but maybe it was meant to by // IWYU pragma: export ?
|
Before sending this to XLS internal reviewers, does this look good @cdleary ? |
Also looks like c_api.cc does not depend on c_api_vast.h anymore.
hzeller
force-pushed
the
feature-20250926-fix-dep-public
branch
from
01b0f1b to
ab6408d
Compare
|
Do you still want to land? Is this superseded by #3184? |
|
Yes, still want to land. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Also looks like c_api.cc does not depend on c_api_vast.h anymore.