Skip to content

Fix dependencies in xls/public #3121

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Fix dependencies in xls/public #3121

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions xls/public/BUILD
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -217,7 +217,6 @@ cc_library(
"//xls/dslx:import_data",
"//xls/dslx:interp_value",
"//xls/dslx:interp_value_from_string",
"//xls/dslx:interp_value_utils",
"//xls/dslx:parse_and_typecheck",
"//xls/dslx:virtualizable_file_system",
"//xls/dslx:warning_kind",
Expand All @@ -234,6 +233,8 @@ cc_library(
"@com_google_absl//absl/log:check",
"@com_google_absl//absl/status",
"@com_google_absl//absl/status:statusor",
"@com_google_absl//absl/types:span",
"@com_google_absl//absl/types:variant",
],
)

Expand Down Expand Up @@ -262,7 +263,6 @@ cc_library(
":c_api_format_preference",
":c_api_impl_helpers",
":c_api_ir_builder",
":c_api_vast",
":runtime_build_actions",
"//xls/common:init_xls",
"//xls/common/file:filesystem",
Expand Down
1 change: 0 additions & 1 deletion xls/public/c_api.cc
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -55,7 +55,6 @@
#include "xls/jit/function_jit.h"
#include "xls/public/c_api_format_preference.h"
#include "xls/public/c_api_impl_helpers.h"
#include "xls/public/c_api_vast.h"
#include "xls/public/runtime_build_actions.h"
#include "xls/solvers/z3_ir_translator.h"
#include "xls/tools/codegen_flags.pb.h"
Expand Down
1 change: 0 additions & 1 deletion xls/public/c_api.h
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -21,7 +21,6 @@
#include "xls/public/c_api_dslx.h"
#include "xls/public/c_api_format_preference.h"
#include "xls/public/c_api_ir_builder.h"
#include "xls/public/c_api_vast.h"
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Here I am unsure; nothing in the header needs this, but maybe it was meant to by // IWYU pragma: export ?


// C API that exposes the functionality in various public headers in a way that
// C-based FFI facilities can easily wrap.
Expand Down
2 changes: 2 additions & 0 deletions xls/public/c_api_dslx.cc
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -24,7 +24,9 @@
#include <variant>
#include <vector>

#include "absl/types/variant.h"
#include "absl/container/flat_hash_map.h"
#include "absl/types/span.h"
#include "absl/log/check.h"
#include "absl/status/status.h"
#include "absl/status/statusor.h"
Expand Down