-
Notifications
You must be signed in to change notification settings - Fork 3.8k
feat(helm): add tpl support for pattern_ingester and ingester_client #16759
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(helm): add tpl support for pattern_ingester and ingester_client #16759
Conversation
Signed-off-by: Paulo Dias <[email protected]>
Signed-off-by: Paulo Dias <[email protected]>
Signed-off-by: Paulo Dias <[email protected]>
…s/loki into helm_improve_pattern_ingester Signed-off-by: Paulo Dias <[email protected]>
…pattern_ingester Signed-off-by: Paulo Dias <[email protected]>
…pattern_ingester Signed-off-by: Paulo Dias <[email protected]>
Signed-off-by: Paulo Dias <[email protected]>
Signed-off-by: Paulo Dias <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM @JStickler
Thanks for the contribution @paulojmdias
Signed-off-by: Paulo Dias <[email protected]>
@jkroepke done, please review 🙌 I also rebased the branch and updated the last CHANGELOG.md entry which has the PR reference missing. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
What this PR does / why we need it:
Which issue(s) this PR fixes:
Fixes #15464
Fixes #12054
Fixes #18652
Special notes for your reviewer:
ingester_client
comes from feat(helm): Add missing server config ingester_client #12054 and seems abandoned.pattern_ingester
does not break any current deployment.compactor_grpc_client
configurationChecklist
CONTRIBUTING.md
guide (required)feat
PRs are unlikely to be accepted unless a case can be made for the feature actually being a bug fix to existing behavior.docs/sources/setup/upgrade/_index.md
deprecated-config.yaml
anddeleted-config.yaml
files respectively in thetools/deprecated-config-checker
directory. Example PR