Skip to content

Conversation

paulojmdias
Copy link
Contributor

@paulojmdias paulojmdias commented Mar 14, 2025

What this PR does / why we need it:

Which issue(s) this PR fixes:
Fixes #15464
Fixes #12054
Fixes #18652

Special notes for your reviewer:

Checklist

  • Reviewed the CONTRIBUTING.md guide (required)
  • Documentation added
  • Tests updated
  • Title matches the required conventional commits format, see here
    • Note that Promtail is considered to be feature complete, and future development for logs collection will be in Grafana Alloy. As such, feat PRs are unlikely to be accepted unless a case can be made for the feature actually being a bug fix to existing behavior.
  • Changes that require user attention or interaction to upgrade are documented in docs/sources/setup/upgrade/_index.md
  • If the change is deprecating or removing a configuration option, update the deprecated-config.yaml and deleted-config.yaml files respectively in the tools/deprecated-config-checker directory. Example PR

@paulojmdias paulojmdias requested a review from a team as a code owner March 14, 2025 10:42
@pull-request-size pull-request-size bot added size/M and removed size/S labels Jul 28, 2025
Copy link
Contributor

@QuentinBisson QuentinBisson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM @JStickler

Thanks for the contribution @paulojmdias

@jkroepke
Copy link
Contributor

jkroepke commented Jul 31, 2025

Could you please add #12054 and #18652 to the list of fixed issues? that would close the duplicate PR on merge.

@paulojmdias
Copy link
Contributor Author

@jkroepke done, please review 🙌

I also rebased the branch and updated the last CHANGELOG.md entry which has the PR reference missing.

Copy link
Contributor

@Jayclifford345 Jayclifford345 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@Jayclifford345 Jayclifford345 enabled auto-merge (squash) August 4, 2025 13:18
@Jayclifford345 Jayclifford345 merged commit 901b2b0 into grafana:main Aug 4, 2025
78 checks passed
@paulojmdias paulojmdias deleted the helm_improve_pattern_ingester branch August 4, 2025 13:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Missing ingester_client Configuration Options in Helm Chart v6.23.0
5 participants