Skip to content

Conversation

aa-shalin
Copy link

@aa-shalin aa-shalin commented Jul 29, 2025

What this PR does / why we need it:
Allows configuration of ingester_client settings via helm. ingester_client settings are typically exposed via loki.yaml.

Ref: https://grafana.com/docs/loki/latest/configure/#supported-contents-and-default-values-of-lokiyaml

Which issue(s) this PR fixes:
N/A

Special notes for your reviewer:

Checklist

  • Reviewed the CONTRIBUTING.md guide (required)
  • Documentation added
  • Tests updated
  • Title matches the required conventional commits format, see here
    • Note that Promtail is considered to be feature complete, and future development for logs collection will be in Grafana Alloy. As such, feat PRs are unlikely to be accepted unless a case can be made for the feature actually being a bug fix to existing behavior.
  • Changes that require user attention or interaction to upgrade are documented in docs/sources/setup/upgrade/_index.md
  • If the change is deprecating or removing a configuration option, update the deprecated-config.yaml and deleted-config.yaml files respectively in the tools/deprecated-config-checker directory. Example PR

@aa-shalin aa-shalin requested a review from a team as a code owner July 29, 2025 21:11
@CLAassistant
Copy link

CLAassistant commented Jul 29, 2025

CLA assistant check
All committers have signed the CLA.

@aa-shalin aa-shalin changed the title fix(helm): allowing ingester_client settings to be configured fix(helm): allow ingester_client settings to be configured Jul 29, 2025
@jkroepke
Copy link
Contributor

Hi, thanks for your PR. We have already #16759 that should cover this.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants