chore(dataobj): return Object on Builder.Flush #18622
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rfratto
force-pushed
the
dataobj-flush-to-object
branch
from
376aa91 to
fefc514
Compare
This commit updates Builder.Flush to return an Object rather than writing bytes to an argument. To support this change, dataobj.Object has two additional methods: - dataobj.Object.Size, to retrieve the full encoded size of the object - dataobj.Object.Reader, to read from the encoded object This API change allows downstream users of dataobj.Builder to stream the encoded object for analysis or uploading, without requiring the caller to retain the entire object in memory at once. In the future, this will be used to reduce the memory overhead of dataobj-consumers by buffering flushed sections on an ephemeral disk instead of in memory.
rfratto
force-pushed
the
dataobj-flush-to-object
branch
from
fefc514 to
a3564cd
Compare
grobinson-grafana
approved these changes
Aug 4, 2025
rfratto
added a commit
that referenced
this pull request
Aug 6, 2025
rfratto
added a commit
that referenced
this pull request
Aug 6, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This commit updates Builder.Flush to return an Object rather than writing bytes to an argument. To support this change, dataobj.Object has two additional methods:
This API change allows downstream users of dataobj.Builder to stream the encoded object for analysis or uploading, without requiring the caller to retain the entire object in memory at once.
In the future, this will be used to reduce the memory overhead of dataobj-consumers by buffering flushed sections on an ephemeral disk instead of in memory.