compiler: Mangle generated method names that conflict with java.lang.Object methods #12332
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Generated gRPC method names in the BlockingV2Stub can conflict with
final methods on
java.lang.Object
(e.g.,toString()
,hashCode()
)for client-streaming and bidi-streaming RPCs. This occurs because
they are generated with no arguments, leading to a compilation error. One such case in #12331.
This change introduces a dedicated list of no-argument method names
from java.lang.Object and applies name-mangling (appending an
underscore) only when generating these specific methods in the
v2 blocking stub.
This resolves the compilation failure while ensuring that the behavior
for all other stubs remains unchanged.
Fixes: #12331