Skip to content

compiler: Mangle generated method names that conflict with java.lang.Object methods #12332

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 4 commits into from
Sep 13, 2025
Merged

compiler: Mangle generated method names that conflict with java.lang.Object methods #12332

Changes from 2 commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
98cf449
compliler: Mangle generated method names that conflict with java.lang…
shivaspeaks Sep 4, 2025
da96d25
address comment
shivaspeaks Sep 7, 2025
64da145
restrict to only blocking v2 call
shivaspeaks Sep 10, 2025
a852f02
address comment
shivaspeaks Sep 11, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
18 changes: 16 additions & 2 deletions compiler/src/java_plugin/cpp/java_generator.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -143,10 +143,23 @@ static std::set<std::string> java_keywords = {
"false",
};

// Methods on java.lang.Object that take no arguments.
static std::set<std::string> java_object_methods = {
"clone",
"finalize",
"getClass",
"hashCode",
"notify",
"notifyAll",
"toString",
"wait",
};

// Adjust a method name prefix identifier to follow the JavaBean spec:
// - decapitalize the first letter
// - remove embedded underscores & capitalize the following letter
// Finally, if the result is a reserved java keyword, append an underscore.
// Finally, if the result is a reserved java keyword or an Object method,
// append an underscore.
static std::string MixedLower(std::string word) {
std::string w;
w += tolower(word[0]);
Expand All @@ -159,7 +172,8 @@ static std::string MixedLower(std::string word) {
after_underscore = false;
}
}
if (java_keywords.find(w) != java_keywords.end()) {
if (java_keywords.find(w) != java_keywords.end() ||
java_object_methods.find(w) != java_object_methods.end()) {
return w + "_";
}
return w;
Expand Down