Skip to content

V3 API improvements #11080

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 4 commits into from
Jul 26, 2025
Merged

V3 API improvements #11080

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
5f61789
expose ach xfer creator
24c02 Jul 18, 2025
df364cd
expose actual activity owner
24c02 Jul 18, 2025
5b69b5c
expose actual hcb code on rpst activities
24c02 Jul 18, 2025
98c1031
ARCAB
24c02 Jul 24, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 5 additions & 0 deletions app/api/api/entities/ach_transfer.rb
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -19,6 +19,11 @@ class AchTransfer < LinkedObjectBase
expose :beneficiary do
expose :recipient_name, as: :name
end

expose_associated User do |ach_transfer, options|
ach_transfer.creator
end

end

def self.entity_name
Expand Down
4 changes: 3 additions & 1 deletion app/api/api/entities/activity.rb
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -14,14 +14,16 @@ class Activity < Base
end

expose_associated User do |activity, options|
activity.user
activity.owner.is_a?(User) ? activity.owner : activity.user
end

expose_associated Transaction do |activity, options|
if activity.trackable.try(:hcb_code).is_a?(HcbCode)
return activity.trackable.try(:hcb_code)
elsif activity.trackable.try(:hcb_code)
HcbCode.find_by_hcb_code(activity.trackable.try(:hcb_code))
elsif (cpt_hcb_code = activity.trackable.try(:canonical_pending_transaction)&.try(:local_hcb_code))
cpt_hcb_code
end
end

Expand Down