-
Notifications
You must be signed in to change notification settings - Fork 38
feat: upgrade Java dependencies #364
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: upgrade Java dependencies #364
Conversation
Signed-off-by: Trevor Dolby <[email protected]>
Signed-off-by: Trevor Dolby <[email protected]>
|
@neeraj-laad can you please review this PR. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, the checks on the PR are not passing. @trevor-dolby-at-ibm-com please can you address those?
|
Looks like it's related to node versions; will take a look. |
* Try with PR only * Try node 16 * node 20 with corrected PR * feat: fix workflow Signed-off-by: Your Name [email protected] * feat: update to node.js 20 Signed-off-by: Trevor Dolby <[email protected]> * feat: update dependencies starter app (ibm-messaging#348) --------- Signed-off-by: Trevor Dolby <[email protected]>
|
Looks like node 20 works with the expected commit messages, and https://github.com/trevor-dolby-at-ibm-com/kafka-java-vertx-starter/actions/runs/11760954876 is green. Probably worth running the actions again to see if the changes help in this repo. |
|
@trevor-dolby-at-ibm-com the workflow still fails but it is much better at showing what is wrong. Can you take a look now and fix? |
|
@neeraj-laad That's looking better as you say, and I think it's complaining about my squash commit message and nothing to do with code as such; I've added another commit with less text in the hope it works that way. |
|
That worked. Thanks @trevor-dolby-at-ibm-com |
|
@trevor-dolby-at-ibm-com I had created a release using your changes but I could not run the app locally and saw these errors: So I deleted the release and tag to make sure everything works before we publish a release as I do not see this issue with older version. Did you notice any such issues in your running locally? |
Updates Java dependencies to latest available level.
jackson-databind is left at 2.16.1 instead of the very latest 2.18.1 because vertx-dependencies 4.5.10 pulls in 2.16.1.
Note that 2.16.1 is not flagged as having security vulnerabilities at https://mvnrepository.com/artifact/com.fasterxml.jackson.core/jackson-databind so the upgrade to 2.18.1 is not critical at this point.
Signed-off-by: Trevor Dolby [email protected]
Checklist