Skip to content

Conversation

@suhaibabsi-inst
Copy link
Contributor

refs: MBL-19501
affects: Student
builds: Student
release note: Fixed issue of hiding “View Discussion” button on Assignment Details page when discussion is closed for comments.

Test Plan

See ticket's description for reproducible steps.

Checklist

  • Follow-up e2e test ticket created
  • A11y checked
  • Tested on phone
  • Tested on tablet
  • Tested in dark mode
  • Tested in light mode
  • Approve from product

…page when discussion is closed for comments

refs: MBL-19501
affects: Student
builds: Student
release note: Fixed issue of hiding “View Discussion” button on Assignment Details page when discussion is closed for comments
@inst-danger
Copy link
Contributor

inst-danger commented Nov 19, 2025

Warnings
⚠️ One or more files are below the minimum test coverage 50%
⚠️ The total test coverage is below the minimum 90%

Release Note:

Fixed issue of hiding “View Discussion” button on Assignment Details page when discussion is closed for comments

Affected Apps: Student

Builds: Student

MBL-19501

Coverage New % Master % Delta
Canvas iOS 81.11% 81.06% 0.04%
Horizon/Horizon/Sources/Features/Dashboard/SkillsHighlightsWidget/Data/ProficiencyLevel.swift 0% 0% 0%
Horizon/Horizon/Sources/Features/Notebook/Common/View/HighlightWebView/HighlightWebFeature.swift 0% 0% 0%
Horizon/Horizon/Sources/Features/Notebook/Common/View/HighlightWebView/EnableZoom.swift 0% 0% 0%
Horizon/Horizon/Sources/Common/Domain/GetCoursesInteractor.swift 38.16% 38.16% 0%
Horizon/Horizon/Sources/Features/LearningObjects/Assignment/SubmissionComment/Data/CommentAttachment.swift 0% 0% 0%
Horizon/Horizon/Sources/Features/Account/Notifications/Domain/NotificationSettingsInteractor.swift 0% 0% 0%
Horizon/Horizon/Sources/Common/Utilities/Double+.swift 0% 0% 0%
Horizon/Horizon/Sources/Common/Data/HModuleStatus.swift 0% 0% 0%
Horizon/Horizon/Sources/Features/Session/SessionInteractor.swift 32% 33.33% -1.33%
Horizon/Horizon/Sources/Features/Assist/AssistFlashCard/View/AssistFlashCardViewModel.swift 0% 0% 0%

Generated by 🚫 dangerJS against 1903b91

@inst-danger
Copy link
Contributor

Builds

Commit: Unit tests (1903b91)
Build Number: 792
Built At: Nov 19 11:20 CET (11/19 03:20 AM MST)

Student

@suhaibabsi-inst suhaibabsi-inst changed the title Fixes issue of hiding “View Discussion” button on Assignment Details page when discussion is closed for comments [MBL-19501][S] Fixes issue of hiding “View Discussion” button on Assignment Details page when discussion is closed for comments Nov 19, 2025
Copy link
Contributor

@rh12 rh12 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

QA + 1

Copy link
Contributor

@petkybenedek petkybenedek left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

QA +1

@suhaibabsi-inst suhaibabsi-inst merged commit d4e1ac7 into master Nov 25, 2025
6 checks passed
@suhaibabsi-inst suhaibabsi-inst deleted the bugfix/MBL-19501-Hiding-View-Discussion-Button-In-AssignmentDetails branch November 25, 2025 11:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants