Skip to content

[MBL-19501][S] Fixes issue of hiding “View Discussion” button on Assignment Details page when discussion is closed for comments #3764

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Nov 25, 2025
Merged

[MBL-19501][S] Fixes issue of hiding “View Discussion” button on Assignment Details page when discussion is closed for comments #3764

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
e5f919e
Fixes issue of hiding “View Discussion” button on Assignment Details …
suhaibabsi-inst Nov 19, 2025
1903b91
Unit tests
suhaibabsi-inst Nov 19, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 3 additions & 0 deletions Student/Student/Assignments/AssignmentDetails/StudentAssignmentDetailsPresenter.swift
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -386,6 +386,9 @@ class StudentAssignmentDetailsPresenter {
return false
}

// Always show "View Discussion" button for graded discussions
if assignment?.isDiscussion == true { return false }

return assignment?.lockStatus != .unlocked ||
assignment?.lockedForUser == true ||
assignment?.isSubmittable == false ||
Expand Down
16 changes: 16 additions & 0 deletions ...udentUnitTests/Assignments/AssignmentDetails/StudentAssignmentDetailsPresenterTests.swift
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -412,6 +412,22 @@ class StudentAssignmentDetailsPresenterTests: StudentTestCase {
XCTAssertTrue( presenter.submitAssignmentButtonIsHidden() )
}

func testSubmitAssignmentButtonIsNotHiddenForClosedForCommentsDiscussion() {
Assignment.make(from: .make(
can_submit: false,
locked_for_user: true,
lock_at: Date().addDays(-3),
lock_explanation: "closed for comments",
submission_types: [ .discussion_topic ]
))
XCTAssertFalse( presenter.submitAssignmentButtonIsHidden() )
}

func testSubmitAssignmentButtonIsNotHiddenForUnlockedDiscussion() {
Assignment.make(from: .make(submission_types: [ .discussion_topic ]))
XCTAssertFalse( presenter.submitAssignmentButtonIsHidden() )
}

func testSubmitAssignmentButtonIsNotHiddenForUnlockedQuiz() {
Assignment.make(from: .make(locked_for_user: true, quiz_id: "1"))
Quiz.make(from: .make(id: "1", locked_for_user: false))
Expand Down