-
-
Notifications
You must be signed in to change notification settings - Fork 3.7k
[5.3] Joomla Dialog add support for aria-label #46090
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Closed
4 tasks
I have tested this item ✅ successfully on 8894fd9
Without the patch the aria-label is absent. This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/46090. |
I have tested this item ✅ successfully on 8894fd9 This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/46090. |
RTC This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/46090. |
I have tested this item ✅ successfully on 8894fd9 This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/46090. |
Thank you for the fix @Fedik great teamwork - bringing up and clarifying the issue and also for testing @ceford @alikon @brianteeman @chmst @bembelimen |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
a11y
Accessibility
bug
NPM Resource Changed
This Pull Request can't be tested by Patchtester
PR-5.3-dev
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull Request for Issue #45429
Summary of Changes
Add support for
aria-label
andaria-labelledby
attributes fordialog
in theJoomlaDialog
.The attributes can be set manually during dialog creation.
When it is empty the attribute will be set automatically based on the header text.
Testing Instructions
Apply patch.
Run
npm install
.Open any dialog in backend and check source code for it.
Actual result BEFORE applying this Pull Request
Dialog does not have aria-label attribute
Expected result AFTER applying this Pull Request
Dialog has an aria-label attribute.
Link to documentations
Please select: