Skip to content

Conversation

Fedik
Copy link
Member

@Fedik Fedik commented Sep 13, 2025

Pull Request for Issue #45429

Summary of Changes

Add support for aria-label and aria-labelledby attributes for dialog in the JoomlaDialog.
The attributes can be set manually during dialog creation.
When it is empty the attribute will be set automatically based on the header text.

Testing Instructions

Apply patch.
Run npm install.
Open any dialog in backend and check source code for it.

Actual result BEFORE applying this Pull Request

Dialog does not have aria-label attribute

Expected result AFTER applying this Pull Request

Dialog has an aria-label attribute.

Link to documentations

Please select:

  • Documentation link for docs.joomla.org:
  • No documentation changes for docs.joomla.org needed
  • Pull Request link for manual.joomla.org: TBD
  • No documentation changes for manual.joomla.org needed

@joomla-cms-bot joomla-cms-bot added NPM Resource Changed This Pull Request can't be tested by Patchtester PR-5.3-dev labels Sep 13, 2025
@Fedik Fedik linked an issue Sep 13, 2025 that may be closed by this pull request
@Fedik Fedik changed the title [5.4] Joomla Dialog add support for aria-label [5.3] Joomla Dialog add support for aria-label Sep 13, 2025
@Fedik Fedik added bug a11y Accessibility labels Sep 13, 2025
@ceford
Copy link
Contributor

ceford commented Sep 18, 2025

I have tested this item ✅ successfully on 8894fd9

With the patch, the Batch process dialog has this:

<dialog aria-label="Batch process the selected articles" style="width: 100%; max-width: 800px; height: fit-content;" open="">

Without the patch the aria-label is absent.


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/46090.

@alikon
Copy link
Contributor

alikon commented Sep 18, 2025

I have tested this item ✅ successfully on 8894fd9


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/46090.

@joomla-cms-bot joomla-cms-bot removed a11y Accessibility NPM Resource Changed This Pull Request can't be tested by Patchtester bug PR-5.3-dev labels Sep 18, 2025
@alikon
Copy link
Contributor

alikon commented Sep 18, 2025

RTC


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/46090.

@joomla-cms-bot joomla-cms-bot added the RTC This Pull Request is Ready To Commit label Sep 18, 2025
@alikon alikon added a11y Accessibility bug PR-5.3-dev NPM Resource Changed This Pull Request can't be tested by Patchtester labels Sep 18, 2025
@brianteeman
Copy link
Contributor

I have tested this item ✅ successfully on 8894fd9


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/46090.

@LadySolveig LadySolveig merged commit c65b192 into joomla:5.3-dev Sep 20, 2025
39 checks passed
@joomla-cms-bot joomla-cms-bot removed the RTC This Pull Request is Ready To Commit label Sep 20, 2025
@LadySolveig
Copy link
Contributor

Thank you for the fix @Fedik great teamwork - bringing up and clarifying the issue and also for testing @ceford @alikon @brianteeman @chmst @bembelimen

@Fedik Fedik deleted the dialog-aria-label3 branch September 20, 2025 11:31
@richard67 richard67 added this to the Joomla! 5.3.4 milestone Sep 20, 2025
@richard67 richard67 mentioned this pull request Sep 20, 2025
4 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
a11y Accessibility bug NPM Resource Changed This Pull Request can't be tested by Patchtester PR-5.3-dev
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Dialog headline title
7 participants