Skip to content

[5.3] Joomla Dialog add support for aria-label #46090

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Sep 20, 2025
Merged

[5.3] Joomla Dialog add support for aria-label #46090

Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
8894fd9
Joomla Dialog add support for aria-label
Fedik Sep 13, 2025
13c05a9
Merge branch '5.3-dev' into dialog-aria-label3
LadySolveig Sep 20, 2025
9751a55
Merge branch '5.3-dev' into dialog-aria-label3
LadySolveig Sep 20, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
19 changes: 19 additions & 0 deletions build/media_source/system/js/joomla-dialog.w-c.es6.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -116,6 +116,8 @@ class JoomlaDialog extends HTMLElement {
this.preferredParent = null;
// @internal. Parent of the popupContent for cases when it is HTMLElement. Need for recovery on destroy().
this.popupContentSrcLocation = null;
// @internal. Hold properties addressed directly to <dialog> element, like "aria-".
this.dialogProps = {};

if (!config) return;

Expand All @@ -127,6 +129,13 @@ class JoomlaDialog extends HTMLElement {
}
});

// Check for properties which should be applied to the <dialog> not to the <JoomlaDialog>, like "aria-".
['ariaLabelledby', 'ariaLabel'].forEach((key) => {
if (config[key] !== undefined) {
this.dialogProps[key] = config[key];
}
});

// Check class name
if (config.className) {
this.classList.add(...config.className.split(' '));
Expand Down Expand Up @@ -191,6 +200,11 @@ class JoomlaDialog extends HTMLElement {
this.dialog.addEventListener('close', onClose);
this.appendChild(this.dialog);

// Apply dialog properties if any
Object.entries(this.dialogProps).forEach(([k, v]) => {
this.dialog[k] = v;
});

// Get template parts
this.popupTmplH = this.dialog.querySelector('.joomla-dialog-header');
this.popupTmplB = this.dialog.querySelector('.joomla-dialog-body');
Expand All @@ -214,6 +228,11 @@ class JoomlaDialog extends HTMLElement {
i.classList.add(...this.iconHeader.split(' '));
this.popupTmplH.insertAdjacentElement('afterbegin', i);
}

// Set aria-label if it is still missing
if (!this.dialog.ariaLabel) {
this.dialog.ariaLabel = this.textHeader;
}
}

// Set the body
Expand Down
Loading