-
Couldn't load subscription status.
- Fork 164
Fix: Resolve s2i linux/amd64 build failure by pinning source-to-image v1.5.1 #3144
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: suhas-developer07 The full list of commands accepted by this bot can be found here.
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
|
Welcome @suhas-developer07! It looks like this is your first PR to knative/func 🎉 |
|
Hi @suhas-developer07. Thanks for your PR. I'm waiting for a github.com member to verify that this patch is reasonable to test. If it is, they should reply with Once the patch is verified, the new status will be reflected by the I understand the commands that are listed here. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
|
Verified the fix locally — the s2i linux/amd64 build now completes successfully after adding This resolves the lfstack.push invalid packing runtime crash reported in issue #3140. |
Hi @jrangelramos, This PR fixes the s2i linux/amd64 build failure by pinning source-to-image to v1.5.1. Could you please review and /approve if it looks good? Thanks! |
|
Hi, you deleted the func-yaml schema, accidentally I assume. also you will need to verify the easyCLA. Thanks for the contribution! |
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #3144 +/- ##
==========================================
+ Coverage 58.31% 60.14% +1.82%
==========================================
Files 134 134
Lines 17377 13501 -3876
==========================================
- Hits 10134 8120 -2014
+ Misses 6302 4409 -1893
- Partials 941 972 +31
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
a6d46a5 to
ff67486
Compare
|
@linux-foundation-easycla recheck |
|
Hi @gauron99, thanks for pointing that out! I’ve restored the func-yaml schema and also completed the EasyCLA verification. Please let me know if any other changes are needed. |
|
/ok-to-test |
5d5a0ed to
b705fac
Compare
|
please remove the test data from |
This PR fixes cross-platform build errors when deploying Go functions
from macOS to Linux using the S2I builder. The issue occurred due to
environment inconsistencies (timestamps and GOOS/GOARCH mismatch)
causing runtime crashes like "lfstack.push invalid packing".
This PR fixes the func deploy -b=s2i --platform linux/amd64 build failure that caused runtime crashes like
runtime: lfstack.push invalid packing.
The issue was due to an invalid or missing version reference for github.com/openshift/source-to-image.
replace github.com/openshift/source-to-image => github.com/openshift/source-to-image v1.5.1