Skip to content

Conversation

@suhas-developer07
Copy link

@suhas-developer07 suhas-developer07 commented Oct 24, 2025

This PR fixes cross-platform build errors when deploying Go functions
from macOS to Linux using the S2I builder. The issue occurred due to
environment inconsistencies (timestamps and GOOS/GOARCH mismatch)
causing runtime crashes like "lfstack.push invalid packing".

This PR fixes the func deploy -b=s2i --platform linux/amd64 build failure that caused runtime crashes like
runtime: lfstack.push invalid packing.

The issue was due to an invalid or missing version reference for github.com/openshift/source-to-image.
replace github.com/openshift/source-to-image => github.com/openshift/source-to-image v1.5.1

@knative-prow knative-prow bot requested review from dsimansk and nainaz October 24, 2025 05:17
@linux-foundation-easycla
Copy link

linux-foundation-easycla bot commented Oct 24, 2025

CLA Signed

The committers listed above are authorized under a signed CLA.

@knative-prow
Copy link

knative-prow bot commented Oct 24, 2025

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: suhas-developer07
Once this PR has been reviewed and has the lgtm label, please assign jrangelramos for approval. For more information see the Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@knative-prow knative-prow bot added needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. size/L Denotes a PR that changes 100-499 lines, ignoring generated files. labels Oct 24, 2025
@knative-prow
Copy link

knative-prow bot commented Oct 24, 2025

Welcome @suhas-developer07! It looks like this is your first PR to knative/func 🎉

@knative-prow
Copy link

knative-prow bot commented Oct 24, 2025

Hi @suhas-developer07. Thanks for your PR.

I'm waiting for a github.com member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@suhas-developer07
Copy link
Author

Verified the fix locally — the s2i linux/amd64 build now completes successfully after adding
replace github.com/openshift/source-to-image => github.com/openshift/source-to-image v1.5.1
to go.mod.

This resolves the lfstack.push invalid packing runtime crash reported in issue #3140.

@suhas-developer07
Copy link
Author

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: suhas-developer07 Once this PR has been reviewed and has the lgtm label, please assign jrangelramos for approval. For more information see the Code Review Process.

The full list of commands accepted by this bot can be found here.
Needs approval from an approver in each of these files:

* **[OWNERS](https://github.com/knative/func/blob/main/OWNERS)**

Approvers can indicate their approval by writing /approve in a comment Approvers can cancel approval by writing /approve cancel in a comment

Hi @jrangelramos,

This PR fixes the s2i linux/amd64 build failure by pinning source-to-image to v1.5.1. Could you please review and /approve if it looks good?

Thanks!

@gauron99
Copy link
Contributor

Hi, you deleted the func-yaml schema, accidentally I assume. also you will need to verify the easyCLA. Thanks for the contribution!

@codecov
Copy link

codecov bot commented Oct 24, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 60.14%. Comparing base (b990215) to head (b705fac).
⚠️ Report is 7 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #3144      +/-   ##
==========================================
+ Coverage   58.31%   60.14%   +1.82%     
==========================================
  Files         134      134              
  Lines       17377    13501    -3876     
==========================================
- Hits        10134     8120    -2014     
+ Misses       6302     4409    -1893     
- Partials      941      972      +31     
Flag Coverage Δ
e2e-tests 41.68% <ø> (+2.78%) ⬆️
integration-tests 54.67% <ø> (+2.41%) ⬆️
unit-tests 46.71% <ø> (+0.49%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@knative-prow knative-prow bot added size/S Denotes a PR that changes 10-29 lines, ignoring generated files. and removed size/L Denotes a PR that changes 100-499 lines, ignoring generated files. labels Oct 24, 2025
@suhas-developer07
Copy link
Author

suhas-developer07 commented Oct 24, 2025

@linux-foundation-easycla recheck

@suhas-developer07
Copy link
Author

Hi @gauron99, thanks for pointing that out! I’ve restored the func-yaml schema and also completed the EasyCLA verification. Please let me know if any other changes are needed.

@gauron99
Copy link
Contributor

/ok-to-test

@knative-prow knative-prow bot added ok-to-test Indicates a non-member PR verified by an org member that is safe to test. and removed needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. labels Oct 26, 2025
@gauron99
Copy link
Contributor

please remove the test data from pkg. Theres some absoluteLinks and empty credsStore. These are generated via the tests but not removed yet

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

ok-to-test Indicates a non-member PR verified by an org member that is safe to test. size/S Denotes a PR that changes 10-29 lines, ignoring generated files.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants