Skip to content

Fix: Resolve s2i linux/amd64 build failure by pinning source-to-image v1.5.1 #3144

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 4 commits into
base: main
Choose a base branch
from
+11 −14
Open

Fix: Resolve s2i linux/amd64 build failure by pinning source-to-image v1.5.1 #3144

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
9e190af
Fix:func go build error - s2i linux/amd64
suhas-developer07 Oct 24, 2025
ff67486
FIX:#3144 issue
suhas-developer07 Oct 24, 2025
b705fac
remove debug print and adjust timeout handling
suhas-developer07 Oct 28, 2025
6fd56f2
Fix:removes the unnessarytest data from pkg folder
suhas-developer07 Oct 29, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion .gitignore
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -18,7 +18,7 @@
# Go
/templates/go/cloudevents/go.sum

# JS
# JSwhta
node_modules
/templates/typescript/cloudevents/build
/templates/typescript/http/build
Expand Down
2 changes: 2 additions & 0 deletions go.mod
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -312,3 +312,5 @@ require (
sigs.k8s.io/structured-merge-diff/v4 v4.6.0 // indirect
sigs.k8s.io/yaml v1.6.0 // indirect
)

replace github.com/openshift/source-to-image => github.com/openshift/source-to-image v1.5.1
4 changes: 2 additions & 2 deletions go.sum
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -860,8 +860,8 @@ github.com/opencontainers/selinux v1.12.0 h1:6n5JV4Cf+4y0KNXW48TLj5DwfXpvWlxXplU
github.com/opencontainers/selinux v1.12.0/go.mod h1:BTPX+bjVbWGXw7ZZWUbdENt8w0htPSrlgOOysQaU62U=
github.com/openshift-pipelines/pipelines-as-code v0.31.0 h1:dUUvnwCrhSmr3IYjsywLD7QTNAINetFoLCIO4529nOk=
github.com/openshift-pipelines/pipelines-as-code v0.31.0/go.mod h1:74yRkJfqVzMp2iiq3IBm8Lt1q1EAHMIHb53/Au+2IVM=
github.com/openshift/source-to-image v1.6.0 h1:u5jK0KPOOUEHkUw+6X3Kae0l762yR8aYUm/tZX3oa60=
github.com/openshift/source-to-image v1.6.0/go.mod h1:ZNfsBThrFHlIgkzqz2NyXqAsb8d7eESBiE73zR07BXo=
github.com/openshift/source-to-image v1.5.1 h1:mtV2Nh1jVeLg5S02HIbk3GmGYS912hWCCbASEadAS6M=
github.com/openshift/source-to-image v1.5.1/go.mod h1:ZNfsBThrFHlIgkzqz2NyXqAsb8d7eESBiE73zR07BXo=
github.com/opentracing/opentracing-go v1.1.0/go.mod h1:UkNAQd3GIcIGf0SeVgPpRdFStlNbqXla1AfSYxPUl2o=
github.com/ory/viper v1.7.5 h1:+xVdq7SU3e1vNaCsk/ixsfxE4zylk1TJUiJrY647jUE=
github.com/ory/viper v1.7.5/go.mod h1:ypOuyJmEUb3oENywQZRgeAMwqgOyDqwboO1tj3DjTaM=
Expand Down
4 changes: 3 additions & 1 deletion main.go
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,6 +1,8 @@
package main

import "knative.dev/func/pkg/app"
import (
"knative.dev/func/pkg/app"
)

func main() {
app.Main()
Expand Down
3 changes: 3 additions & 0 deletions pkg/creds/auth.json
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,3 @@
{
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this file is supposed to be deleted

"credsStore": ""
}
1 change: 0 additions & 1 deletion pkg/oci/testdata/test-links/...validName.lnk
View file
Open in desktop
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this file is not supposed to be deleted, take a look at the diff. There should not be any deleted files in this PR

This file was deleted.

1 change: 0 additions & 1 deletion pkg/oci/testdata/test-links/...validName.txt
View file
Open in desktop
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

same, dont delete

This file was deleted.

1 change: 0 additions & 1 deletion pkg/oci/testdata/test-links/a.lnk
View file
Open in desktop

This file was deleted.

1 change: 0 additions & 1 deletion pkg/oci/testdata/test-links/a.txt
View file
Open in desktop

This file was deleted.

1 change: 0 additions & 1 deletion pkg/oci/testdata/test-links/b/c/linkToParent
View file
Open in desktop
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

none of the files here either, dont delete

This file was deleted.

1 change: 0 additions & 1 deletion pkg/oci/testdata/test-links/b/linkOutsideRootsParent
View file
Open in desktop
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

same, dont delete

This file was deleted.

1 change: 0 additions & 1 deletion pkg/oci/testdata/test-links/b/linkToCurrentDir
View file
Open in desktop

This file was deleted.

1 change: 0 additions & 1 deletion pkg/oci/testdata/test-links/b/linkToRoot
View file
Open in desktop

This file was deleted.

1 change: 0 additions & 1 deletion pkg/oci/testdata/test-links/b/linkToRootsParent
View file
Open in desktop

This file was deleted.

1 change: 0 additions & 1 deletion pkg/oci/testdata/test-links/linkToRoot
View file
Open in desktop
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

same, dont delete

This file was deleted.