Skip to content

improve: UX Enhancements in workspace summary #473

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 9 commits into
base: notebooks-v2
Choose a base branch
from

Conversation

dominikkawka
Copy link

closes: #461, #462, #463,
related: #458

image
image

Copy link

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:
Once this PR has been reviewed and has the lgtm label, please assign ederign for approval. For more information see the Kubernetes Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@google-oss-prow google-oss-prow bot added area/frontend area - related to frontend components area/v2 area - version - kubeflow notebooks v2 labels Jul 8, 2025
@dominikkawka dominikkawka changed the title Improve: UX Enhancements in workspace summary improve: UX Enhancements in workspace summary Jul 8, 2025
Signed-off-by: DominikKawka <[email protected]>
@paulovmr
Copy link

paulovmr commented Jul 8, 2025

Hi @jenny-s51 , could you take a look at these changes please?

/ok-to-test
/assign @jenny-s51

Copy link
Member

@jenny-s51 jenny-s51 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for making these changes and great work here @dominikkawka ! Just one comment below - I put up a PR to support PF utility classes. Once it's merged you can consume the changes and apply the code suggestions so we follow best practices for Patternfly component styling.

#476 cc @paulovmr , if you could PTAL when you have a moment it would be much appreciated so we can unblock this. Thanks a lot here 🚀

@@ -65,7 +65,9 @@ const WorkspaceKindSummaryExpandableCard: React.FC<WorkspaceKindSummaryExpandabl
<Flex wrap="wrap">
<SectionFlex title="Total GPUs in use">
<FlexItem>
<Content>
<Content
style={{ fontSize: LargeFontSize.value, fontWeight: BoldFontWeight.value }}
Copy link
Member

@jenny-s51 jenny-s51 Jul 9, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

When #476 is merged, we can apply the corresponding utility classes here:

Suggested change
style={{ fontSize: LargeFontSize.value, fontWeight: BoldFontWeight.value }}
className="pf-v6-u-font-size-4xl pf-v6-u-font-weight-bold"

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @jenny-s51 , #476 is now merged.

Copy link
Member

@jenny-s51 jenny-s51 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Enhancements LGTM @dominikkawka!

Can we get your signoff here as well @tobiastal? Just a quick question for you on the Idle GPU Workspaces too. Currently it looks like this:

Screenshot 2025-07-10 at 12 36 13 PM

For consistency should we update this to be left aligned?

I.e.:
Screenshot 2025-07-10 at 12 33 23 PM

@tobiastal
Copy link

Hey @jenny-s51
This all looks amazing! I really love the left-aligned version.
Just one small note- can we make the spacing between the heading and the description consistent across all three items? Specifically, the spacing under “Top GPU Consumer Namespaces” could be a bit tighter to match the others.

image

@jenny-s51
Copy link
Member

Thank you for your review @tobiastal - yes, great catch!

@dominikkawka I've PR-ed your branch with the changes: dominikkawka#1

Can you rebase your branch with the latest and then pull in the changes? Then it should be all set to merge. 🚀

dominikkawka and others added 3 commits July 14, 2025 21:00
fix(ws): apply left alignment and fix padding to match other items
Signed-off-by: DominikKawka <[email protected]>
Copy link
Member

@jenny-s51 jenny-s51 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the updates @dominikkawka - LGTM.

@google-oss-prow google-oss-prow bot added the lgtm label Jul 16, 2025
Copy link

@paulovmr paulovmr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@jenny-s51
Copy link
Member

Hi @ederign, when you have a moment, can you please kindly take a look? If you can help us merge this one would be much appreciated. Thank you 🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/frontend area - related to frontend components area/v2 area - version - kubeflow notebooks v2 lgtm ok-to-test size/M
Projects
Status: Needs Triage
Development

Successfully merging this pull request may close these issues.

4 participants