Add Go-based validation utility for steering committee election bios #8596

cblecker · 2025-09-09T01:35:30Z

Summary

Replace shell-based bio validation with comprehensive Go utility
Standardize election candidate file formats to use proper YAML headers
Add enhanced validation for template compliance and filename consistency

Changes

New Go utility (hack/verify-steering-election-tool.go) with YAML parsing, filename validation, and template compliance checking
Updated shell script (hack/verify-steering-election.sh) to invoke Go utility
Standardized YAML headers in 2025-GB candidate files and nomination template
Updated dependencies (yaml.v3, golang.org/x mod, k8s.io/enhancements) while maintaining Go 1.22.4 compatibility

Features

Proper YAML validation using gopkg.in/yaml.v3 instead of regex patterns
Filename format validation (candidate-username.md matches GitHub ID in header)
Template section validation (SIGS, What I have done, What I'll do, Resources About Me)
Unified validation for both regular steering and GB elections
Applied only to 2025+ elections (preserves historical files)

Test Plan

All existing verification tests pass (make verify)
YAML header parsing validates correctly
Filename/GitHub ID matching works
Template compliance checking functions
Performance remains excellent (sub-second execution)

Copilot

Pull Request Overview

This PR adds a comprehensive Go-based validation utility for steering committee election candidate bios while standardizing the file formats and headers to use proper YAML structure.

Replaces shell-based validation with a comprehensive Go utility that supports YAML parsing, filename validation, and template compliance checking
Standardizes YAML headers in 2025-GB candidate files and nomination template to use proper YAML structure
Updates dependencies to maintain Go 1.22.4 compatibility while adding yaml.v3 support

Reviewed Changes

Copilot reviewed 9 out of 10 changed files in this pull request and generated 2 comments.

Show a summary per file

File	Description
sigs.yaml	Restructured YAML format to use proper list syntax
hack/verify-steering-election.sh	Replaced shell logic with Go utility invocation
hack/verify-steering-election-tool.go	New comprehensive validation utility with YAML parsing and template checking
go.mod	Updated dependencies for yaml.v3 and newer package versions
elections/steering/2025/nomination-template.md	Fixed YAML header structure for proper parsing
elections/steering/2025-GB/*.md	Added missing YAML info fields to candidate files

_{Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.}

hack/verify-steering-election-tool.go

k8s-ci-robot · 2025-09-09T18:58:31Z

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: cblecker
Once this PR has been reviewed and has the lgtm label, please assign soltysh for approval. For more information see the Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

~~elections/steering/2025/OWNERS~~ [cblecker]
elections/steering/2025-GB/OWNERS
~~hack/OWNERS~~ [cblecker]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

cblecker · 2025-09-09T20:30:44Z

/hold
for review

cblecker · 2025-09-12T16:43:45Z

/test all

- Update 2025-GB candidate files to include full YAML header structure - Fix YAML info section to use map format instead of list format - Update 2025 nomination template to match new YAML structure - Ensure consistency across all election file formats 🤖 Generated with [Claude Code](https://claude.ai/code) Co-Authored-By: Claude <[email protected]>

- Create new Go utility with enhanced validation capabilities - Validate YAML header format using gopkg.in/yaml.v3 library - Check filename format matches GitHub ID in header - Verify required template sections are present - Support both regular steering and GB election formats - Apply validation only to elections from 2025 forward - Update shell script to invoke Go utility Features: - Proper YAML parsing instead of regex validation - Unified validation logic for all election types - Better error messages for malformed headers - Type-safe validation of candidate bio structure 🤖 Generated with [Claude Code](https://claude.ai/code) Co-Authored-By: Claude <[email protected]>

🤖 Generated with [Claude Code](https://claude.ai/code) Co-Authored-By: Claude <[email protected]>

Replace hard-coded year range ending at 2030 with a dynamic approach that calculates the end year as current year + 5. This eliminates the need for manual updates and ensures the tool continues working without maintenance as time progresses. 🤖 Generated with [Claude Code](https://claude.ai/code) Co-Authored-By: Claude <[email protected]>

Update regex to match exactly 61 dashes instead of 3+ for better consistency and error detection. This matches the actual format used in all candidate files and will help catch formatting errors. 🤖 Generated with [Claude Code](https://claude.ai/code) Co-Authored-By: Claude <[email protected]>

- Add startYear constant set to 2026 for easier configuration - Update findBioFiles to use startYear constant instead of hardcoded 2025 - Update comments to reference the constant instead of specific years 🤖 Generated with [Claude Code](https://claude.ai/code) Co-Authored-By: Claude <[email protected]>

- Add tests for extractYAMLHeader function with various dash counts and formats - Add tests for countWords function with different content types - Add tests for validateFileNameAndGitHubID with valid/invalid formats - Add tests for validateTemplateCompliance with required fields and sections - Add tests for findBioFiles function with year filtering logic - All tests cover both success and error cases for robust validation 🤖 Generated with [Claude Code](https://claude.ai/code) Co-Authored-By: Claude <[email protected]>

Copilot

Pull Request Overview

Copilot reviewed 8 out of 8 changed files in this pull request and generated 2 comments.

_{Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.}

hack/verify-steering-election-tool.go

hack/verify-steering-election-tool_test.go

reylejano · 2025-09-12T19:24:05Z

/lgtm
/assign @sreeram-venkitesh @npolshakova @arujjval

k8s-ci-robot added the cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. label Sep 9, 2025

k8s-ci-robot requested review from jberkus and soltysh September 9, 2025 01:35

cblecker requested a review from Copilot September 9, 2025 01:36

This comment was marked as outdated.

Sign in to view

cblecker force-pushed the election-bio-tool branch from 35c0c33 to 65fa27e Compare September 9, 2025 02:35

k8s-ci-robot added size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. and removed size/L Denotes a PR that changes 100-499 lines, ignoring generated files. labels Sep 9, 2025

cblecker requested a review from Copilot September 9, 2025 02:38

This comment was marked as outdated.

Sign in to view

cblecker force-pushed the election-bio-tool branch from 65fa27e to f60d1d0 Compare September 9, 2025 02:43

cblecker requested a review from Copilot September 9, 2025 02:43

Copilot AI reviewed Sep 9, 2025

View reviewed changes

hack/verify-steering-election-tool.go Outdated Show resolved Hide resolved

hack/verify-steering-election-tool.go Show resolved Hide resolved

k8s-ci-robot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Sep 9, 2025

cblecker force-pushed the election-bio-tool branch from f60d1d0 to f7d4906 Compare September 9, 2025 16:51

k8s-ci-robot removed the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Sep 9, 2025

cblecker force-pushed the election-bio-tool branch from f7d4906 to d4f7c4a Compare September 9, 2025 18:58

k8s-ci-robot added size/L Denotes a PR that changes 100-499 lines, ignoring generated files. and removed size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. labels Sep 9, 2025

cblecker mentioned this pull request Sep 9, 2025

Fix bash-based word count validation for steering elections #8602

Merged

k8s-ci-robot added do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. labels Sep 9, 2025

cblecker force-pushed the election-bio-tool branch from d4f7c4a to c8949f1 Compare September 10, 2025 19:29

k8s-ci-robot removed the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Sep 10, 2025

cblecker and others added 7 commits September 12, 2025 10:13

Replace deprecated io/ioutil with os.ReadFile

8036b28

🤖 Generated with [Claude Code](https://claude.ai/code) Co-Authored-By: Claude <[email protected]>

cblecker force-pushed the election-bio-tool branch from c8949f1 to fad9166 Compare September 12, 2025 17:13

k8s-ci-robot added size/XL Denotes a PR that changes 500-999 lines, ignoring generated files. and removed size/L Denotes a PR that changes 100-499 lines, ignoring generated files. labels Sep 12, 2025

cblecker requested a review from Copilot September 12, 2025 17:14

Copilot AI reviewed Sep 12, 2025

View reviewed changes

hack/verify-steering-election-tool.go Show resolved Hide resolved

hack/verify-steering-election-tool_test.go Show resolved Hide resolved

k8s-ci-robot assigned arujjval, npolshakova, sreeram-venkitesh and reylejano Sep 12, 2025

k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Sep 12, 2025

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

Add Go-based validation utility for steering committee election bios #8596

Add Go-based validation utility for steering committee election bios #8596

cblecker commented Sep 9, 2025

Uh oh!

This comment was marked as outdated.

Uh oh!

This comment was marked as outdated.

Uh oh!

Copilot AI left a comment

Uh oh!

Uh oh!

Uh oh!

k8s-ci-robot commented Sep 9, 2025

Uh oh!

cblecker commented Sep 9, 2025

Uh oh!

cblecker commented Sep 12, 2025

Uh oh!

Copilot AI left a comment

Uh oh!

Uh oh!

Uh oh!

reylejano commented Sep 12, 2025

Uh oh!

Uh oh!

Add Go-based validation utility for steering committee election bios #8596

Are you sure you want to change the base?

Add Go-based validation utility for steering committee election bios #8596

Conversation

cblecker commented Sep 9, 2025

Summary

Changes

Features

Test Plan

Uh oh!

This comment was marked as outdated.

Uh oh!

This comment was marked as outdated.

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull Request Overview

Reviewed Changes

Uh oh!

Uh oh!

Uh oh!

k8s-ci-robot commented Sep 9, 2025

Uh oh!

cblecker commented Sep 9, 2025

Uh oh!

cblecker commented Sep 12, 2025

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull Request Overview

Uh oh!

Uh oh!

Uh oh!

reylejano commented Sep 12, 2025

Uh oh!

Uh oh!