Skip to content

Conversation

Prashant-thakur77
Copy link
Contributor

@Prashant-thakur77 Prashant-thakur77 commented Oct 8, 2025

Description

Please refer to learningequality/studio#5416 for cross Reference on the issue(@AllanOXDi )
The KModal component was inheriting red text color and center alignment from parent table components when used in delete/restore dialogs, causing:

  1. Title and content text appearing red when they shouldn't
  2. Text being center-aligned instead of properly aligned for LTR/RTL

when used in Admin->channels due to inherited parent property .

Fixed this by adding proper styles directly to the KModal component in KDS repository.

Issue addressed

Before/After
Screenshot From 2025-10-06 21-23-49
Screenshot From 2025-10-06 21-23-58

Screenshot From 2025-10-08 15-04-43 Screenshot From 2025-10-08 15-04-33

Changelog

fixed this by adding proper styles directly to the KModal component

  • Description: Prevent KModal's title and content text to unexpectedly inherit parent styles (by explicitly defining proper styles)
  • Products impact: bugfix
  • Addresses: KModal text color inheritance and RTL alignment issues in Studio admin dialogs
  • Components: KModal
  • Breaking: no
  • Impacts a11y: Proper RTL support
  • Guidance: -

@Prashant-thakur77
Copy link
Contributor Author

Hello @AllanOXDi, I've completed the KModal style inheritance fixes. One question I had was regarding the title styling - I've used bold weight, but I'm open to your guidance if you'd prefer a different approach(As it was not set as that before
). Please let me know of any changes you'd like during your review.

@AllanOXDi
Copy link
Member

Thanks @Prashant-thakur77 - I will take a look!

@AllanOXDi
Copy link
Member

Could you make sure that all checks are passing?

@Prashant-thakur77
Copy link
Contributor Author

sure.

@Prashant-thakur77
Copy link
Contributor Author

Prashant-thakur77 commented Oct 8, 2025

Could you make sure that all checks are passing?

Updated the pr to fix linting issues.

@AllanOXDi
Copy link
Member

Thank you

@AllanOXDi AllanOXDi self-requested a review October 9, 2025 16:28
Copy link
Member

@AllanOXDi AllanOXDi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copy link
Contributor

Percy Visual Test Results

Percy Dashboard: View Detailed Report

Environment:

  • Node.js Version: 18.x
  • OS: Ubuntu-latest

Instructions for Reviewers:

  • Click on the Percy Dashboard link to view detailed visual diffs.
  • Review the visual changes highlighted in the report.
  • Approve or request changes based on the visual differences.

@MisRob MisRob changed the title Fix KModal text color inheritance and alignment issues Prevent KModal's title and content text to unexpectedly inherint parent styles Oct 13, 2025
@MisRob MisRob changed the title Prevent KModal's title and content text to unexpectedly inherint parent styles Prevent KModal's title and content text to unexpectedly inherit parent styles Oct 13, 2025
@MisRob MisRob merged commit 437ca4e into learningequality:develop Oct 13, 2025
15 checks passed
@MisRob
Copy link
Member

MisRob commented Oct 13, 2025

@Prashant-thakur77 @AllanOXDi

I think we will release a new version of KDS tomorrow - then after it's installed in Studio, you can rebase your Studio PRs on top of the latest unstable.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants