-
Notifications
You must be signed in to change notification settings - Fork 103
Prevent KModal's title and content text to unexpectedly inherit parent styles #1138
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Prevent KModal's title and content text to unexpectedly inherit parent styles #1138
Conversation
Hello @AllanOXDi, I've completed the KModal style inheritance fixes. One question I had was regarding the title styling - I've used bold weight, but I'm open to your guidance if you'd prefer a different approach(As it was not set as that before |
Thanks @Prashant-thakur77 - I will take a look! |
Could you make sure that all checks are passing? |
sure. |
Updated the pr to fix linting issues. |
Thank you |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks @Prashant-thakur77
Percy Visual Test ResultsPercy Dashboard: View Detailed Report Environment:
Instructions for Reviewers:
|
I think we will release a new version of KDS tomorrow - then after it's installed in Studio, you can rebase your Studio PRs on top of the latest |
Description
Please refer to learningequality/studio#5416 for cross Reference on the issue(@AllanOXDi )
The KModal component was inheriting red text color and center alignment from parent table components when used in delete/restore dialogs, causing:
when used in Admin->channels due to inherited parent property .
Fixed this by adding proper styles directly to the KModal component in KDS repository.
Issue addressed
Before/After


Changelog
fixed this by adding proper styles directly to the KModal component