Skip to content

docker -> docker-compose #3644

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Mar 26, 2025
Merged

docker -> docker-compose #3644

merged 1 commit into from
Mar 26, 2025

Conversation

@ndr-ds
Copy link
Contributor

@ndr-ds ndr-ds commented Mar 25, 2025

Motivation

Docker as a file name here is a bit ambiguous, and this tests only docker compose

Proposal

Change name to docker-compose instead

Test Plan

CI

Release Plan

  • Nothing to do / These changes follow the usual release cycle.

This was referenced Mar 25, 2025
Merged
Merged
Merged
Merged
Merged
Closed
Closed
@ndr-ds Graphite App
Copy link
Contributor Author

ndr-ds commented Mar 25, 2025 •
edited
Loading

This stack of pull requests is managed by Graphite. Learn more about stacking.

This was referenced Mar 25, 2025
Closed
Closed
@ndr-ds ndr-ds force-pushed the 03-25-docker_-_docker-compose branch 2 times, most recently from 8eb65d3 to 68ecbed Compare March 25, 2025 16:46
@ndr-ds ndr-ds force-pushed the 03-19-more_dashboard_changes branch from 0c470f7 to e858344 Compare March 25, 2025 16:46
@ndr-ds ndr-ds requested review from Twey, afck, christos-h, jvff and ma2bd March 25, 2025 20:33
@ndr-ds ndr-ds force-pushed the 03-19-more_dashboard_changes branch from e858344 to 53cb721 Compare March 25, 2025 21:17
@ndr-ds ndr-ds force-pushed the 03-25-docker_-_docker-compose branch from 68ecbed to 4b37563 Compare March 25, 2025 21:17
This was referenced Mar 25, 2025
Merged
Merged
@ndr-ds ndr-ds force-pushed the 03-25-docker_-_docker-compose branch from 4b37563 to 55b1403 Compare March 26, 2025 14:14
@ndr-ds ndr-ds force-pushed the 03-19-more_dashboard_changes branch from 53cb721 to 75330b6 Compare March 26, 2025 14:14
@ndr-ds Graphite App
Copy link
Contributor Author

ndr-ds commented Mar 26, 2025 •
edited
Loading

Merge activity

  • Mar 26, 10:14 AM EDT: A user started a stack merge that includes this pull request via Graphite.
  • Mar 26, 10:15 AM EDT: Graphite rebased this pull request as part of a merge.
  • Mar 26, 10:17 AM EDT: A user merged this pull request with Graphite.

@ndr-ds ndr-ds changed the base branch from 03-19-more_dashboard_changes to graphite-base/3644 March 26, 2025 14:14
@ndr-ds ndr-ds changed the base branch from graphite-base/3644 to main March 26, 2025 14:14
@ndr-ds ndr-ds force-pushed the 03-25-docker_-_docker-compose branch from 55b1403 to d9ae6b5 Compare March 26, 2025 14:15
@ndr-ds ndr-ds merged commit ab55455 into main Mar 26, 2025
25 checks passed
@ndr-ds ndr-ds deleted the 03-25-docker_-_docker-compose branch March 26, 2025 14:17
This was referenced Mar 26, 2025
Merged
Merged
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@ma2bd ma2bd ma2bd approved these changes

@afck afck Awaiting requested review from afck

@christos-h christos-h Awaiting requested review from christos-h

@jvff jvff Awaiting requested review from jvff

@Twey Twey Awaiting requested review from Twey

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@ndr-ds @ma2bd