Skip to content

Conversation

@ndr-ds
Copy link
Contributor

@ndr-ds ndr-ds commented Mar 25, 2025

Motivation

Other databases support this (including dual store, which uses RocksDB)

Proposal

Add support for namespace not to be provided, and use default in that case, aligning this with other databases implementation

Test Plan

CI

Release Plan

  • Nothing to do / These changes follow the usual release cycle.

@ma2bd
Copy link
Contributor

ma2bd commented Mar 25, 2025

@ndr-ds Can you update test_rocks_db_storage_config_from_str to cover the change?

Copy link
Contributor Author

ndr-ds commented Mar 26, 2025

Ah, right. Will do

@ndr-ds ndr-ds force-pushed the 03-25-support_default_namespace_on_rocksdb branch from 99f0d12 to 36bb92d Compare March 26, 2025 02:58
@ndr-ds ndr-ds force-pushed the 03-25-support_default_namespace_on_rocksdb branch from 36bb92d to ad37184 Compare March 26, 2025 14:14
@ndr-ds ndr-ds force-pushed the 03-25-docker_-_docker-compose branch from 4b37563 to 55b1403 Compare March 26, 2025 14:14
Copy link
Contributor Author

ndr-ds commented Mar 26, 2025

Merge activity

  • Mar 26, 10:14 AM EDT: A user started a stack merge that includes this pull request via Graphite.
  • Mar 26, 10:18 AM EDT: A user merged this pull request with Graphite.

@ndr-ds ndr-ds changed the base branch from 03-25-docker_-_docker-compose to graphite-base/3648 March 26, 2025 14:15
@ndr-ds ndr-ds changed the base branch from graphite-base/3648 to main March 26, 2025 14:17
@ndr-ds ndr-ds force-pushed the 03-25-support_default_namespace_on_rocksdb branch from ad37184 to ab5f782 Compare March 26, 2025 14:17
@ndr-ds ndr-ds merged commit 87cb629 into main Mar 26, 2025
8 checks passed
@ndr-ds ndr-ds deleted the 03-25-support_default_namespace_on_rocksdb branch March 26, 2025 14:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants