-
Notifications
You must be signed in to change notification settings - Fork 2.2k
Actually use backend config #3876
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced May 2, 2025
This stack of pull requests is managed by Graphite. Learn more about stacking. |
This was referenced May 2, 2025
Merged
Merged
22bfc47 to
548b6d7
Compare
fa5e6e5 to
40dc1bb
Compare
548b6d7 to
ec65e62
Compare
0c1bef2 to
80c2534
Compare
ma2bd
approved these changes
May 6, 2025
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
assuming this is tested in CI
|
Sorry, I've updated the test plan. It's not tested in CI, but I've deployed a network with this change |
1c05985 to
a4d2d18
Compare
80c2534 to
29245fa
Compare
29245fa to
5395c3f
Compare
5395c3f to
93d807b
Compare
93d807b to
8a865ae
Compare
This was referenced May 9, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.

Motivation
We were defining this config, but AFAIU we weren't actually using it
Proposal
Use the config
Test Plan
Deployed a network with this change
Release Plan