Skip to content

Conversation

@ndr-ds
Copy link
Contributor

@ndr-ds ndr-ds commented May 2, 2025

Motivation

We were defining this config, but AFAIU we weren't actually using it

Proposal

Use the config

Test Plan

Deployed a network with this change

Release Plan

  • Nothing to do / These changes follow the usual release cycle.

Copy link
Contributor Author

ndr-ds commented May 2, 2025

Copy link
Contributor

@ma2bd ma2bd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

assuming this is tested in CI

Copy link
Contributor Author

ndr-ds commented May 6, 2025

Sorry, I've updated the test plan. It's not tested in CI, but I've deployed a network with this change

@ndr-ds ndr-ds force-pushed the 05-01-make_release_the_default_mode_for_dockerfile branch from 1c05985 to a4d2d18 Compare May 7, 2025 17:10
@ndr-ds ndr-ds force-pushed the 05-02-actually_use_backend_config branch from 80c2534 to 29245fa Compare May 7, 2025 17:10
@ndr-ds ndr-ds changed the base branch from 05-01-make_release_the_default_mode_for_dockerfile to graphite-base/3876 May 7, 2025 19:09
@ndr-ds ndr-ds force-pushed the graphite-base/3876 branch from a4d2d18 to 03c7875 Compare May 7, 2025 19:10
@ndr-ds ndr-ds force-pushed the 05-02-actually_use_backend_config branch from 29245fa to 5395c3f Compare May 7, 2025 19:10
@graphite-app graphite-app bot changed the base branch from graphite-base/3876 to main May 7, 2025 19:11
@ndr-ds ndr-ds force-pushed the 05-02-actually_use_backend_config branch from 5395c3f to 93d807b Compare May 7, 2025 19:11
Copy link
Contributor Author

ndr-ds commented May 9, 2025

Merge activity

  • May 9, 5:25 PM EDT: A user started a stack merge that includes this pull request via Graphite.
  • May 9, 5:25 PM EDT: @ndr-ds merged this pull request with Graphite.

@ndr-ds ndr-ds merged commit 1c504b5 into main May 9, 2025
1 check passed
@ndr-ds ndr-ds deleted the 05-02-actually_use_backend_config branch May 9, 2025 21:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants