-
Notifications
You must be signed in to change notification settings - Fork 2.2k
Use NetworkTopologyStrategy instead of SimpleStrategy #3880
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
ndr-ds
merged 1 commit into
main
from
04-30-use_networktopologystrategy_instead_of_simplestrategy
May 9, 2025
Merged
Use NetworkTopologyStrategy instead of SimpleStrategy #3880
ndr-ds
merged 1 commit into
main
from
04-30-use_networktopologystrategy_instead_of_simplestrategy
May 9, 2025
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced May 2, 2025
This stack of pull requests is managed by Graphite. Learn more about stacking. |
This was referenced May 2, 2025
Merged
Merged
8473b0c to
8e182f5
Compare
e6786ca to
11e93bc
Compare
MathieuDutSik
approved these changes
May 5, 2025
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Accept as this is the strategy used in datacenters.
That being said, if you want to do something more subtle like 2 replicas in one place and 2 in another place, the code will have to change.
8e182f5 to
9c115ba
Compare
5f7522f to
6b804f1
Compare
9c115ba to
8518db2
Compare
6b804f1 to
4930e8e
Compare
5a44805 to
73fd415
Compare
4930e8e to
22d7171
Compare
73fd415 to
54b8617
Compare
22d7171 to
32eb499
Compare
54b8617 to
794c64e
Compare
794c64e to
4b7392f
Compare
05a929a to
0d5275a
Compare
afck
approved these changes
May 7, 2025
0d5275a to
46bf043
Compare
48d214f to
fcca14e
Compare
5f0e62a to
1971bcf
Compare
6bfa2ed to
8ad0f96
Compare
1971bcf to
2a07fcc
Compare
This was referenced May 9, 2025
8ad0f96 to
bf8f47e
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.

Motivation
SimpleStrategyis not recommended to be used in productionProposal
Use the recommended production setting
Test Plan
CI + deploy network with this
Release Plan