Skip to content

Conversation

@ndr-ds
Copy link
Contributor

@ndr-ds ndr-ds commented May 2, 2025

Motivation

SimpleStrategy is not recommended to be used in production

Proposal

Use the recommended production setting

Test Plan

CI + deploy network with this

Release Plan

  • Nothing to do / These changes follow the usual release cycle.

This was referenced May 2, 2025
@ndr-ds ndr-ds force-pushed the 04-30-use_networktopologystrategy_instead_of_simplestrategy branch from 8473b0c to 8e182f5 Compare May 2, 2025 20:05
@ndr-ds ndr-ds force-pushed the 04-14-make_scylladb_replication_factor_configurable branch from e6786ca to 11e93bc Compare May 2, 2025 20:05
@ndr-ds ndr-ds marked this pull request as ready for review May 5, 2025 12:12
Copy link
Contributor

@MathieuDutSik MathieuDutSik left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Accept as this is the strategy used in datacenters.
That being said, if you want to do something more subtle like 2 replicas in one place and 2 in another place, the code will have to change.

@ndr-ds ndr-ds force-pushed the 04-30-use_networktopologystrategy_instead_of_simplestrategy branch from 8e182f5 to 9c115ba Compare May 5, 2025 21:00
@ndr-ds ndr-ds force-pushed the 04-14-make_scylladb_replication_factor_configurable branch 2 times, most recently from 5f7522f to 6b804f1 Compare May 5, 2025 21:38
@ndr-ds ndr-ds force-pushed the 04-30-use_networktopologystrategy_instead_of_simplestrategy branch from 9c115ba to 8518db2 Compare May 5, 2025 21:38
@ndr-ds ndr-ds force-pushed the 04-14-make_scylladb_replication_factor_configurable branch from 6b804f1 to 4930e8e Compare May 6, 2025 02:43
@ndr-ds ndr-ds force-pushed the 04-30-use_networktopologystrategy_instead_of_simplestrategy branch 2 times, most recently from 5a44805 to 73fd415 Compare May 6, 2025 14:51
@ndr-ds ndr-ds force-pushed the 04-14-make_scylladb_replication_factor_configurable branch from 4930e8e to 22d7171 Compare May 6, 2025 14:51
@ndr-ds ndr-ds force-pushed the 04-30-use_networktopologystrategy_instead_of_simplestrategy branch from 73fd415 to 54b8617 Compare May 6, 2025 17:34
@ndr-ds ndr-ds force-pushed the 04-14-make_scylladb_replication_factor_configurable branch from 22d7171 to 32eb499 Compare May 6, 2025 17:34
@ndr-ds ndr-ds changed the base branch from 04-14-make_scylladb_replication_factor_configurable to graphite-base/3880 May 6, 2025 20:50
@ndr-ds ndr-ds force-pushed the 04-30-use_networktopologystrategy_instead_of_simplestrategy branch from 54b8617 to 794c64e Compare May 6, 2025 20:51
@ndr-ds ndr-ds force-pushed the graphite-base/3880 branch from 32eb499 to 05a929a Compare May 6, 2025 20:51
@ndr-ds ndr-ds changed the base branch from graphite-base/3880 to 04-14-make_scylladb_replication_factor_configurable May 6, 2025 20:52
@ndr-ds ndr-ds force-pushed the 04-30-use_networktopologystrategy_instead_of_simplestrategy branch from 794c64e to 4b7392f Compare May 6, 2025 22:17
@ndr-ds ndr-ds force-pushed the 04-14-make_scylladb_replication_factor_configurable branch from 05a929a to 0d5275a Compare May 6, 2025 22:17
@ndr-ds ndr-ds force-pushed the 04-14-make_scylladb_replication_factor_configurable branch from 0d5275a to 46bf043 Compare May 7, 2025 17:10
@ndr-ds ndr-ds force-pushed the 04-30-use_networktopologystrategy_instead_of_simplestrategy branch 2 times, most recently from 48d214f to fcca14e Compare May 7, 2025 18:23
@ndr-ds ndr-ds force-pushed the 04-14-make_scylladb_replication_factor_configurable branch 2 times, most recently from 5f0e62a to 1971bcf Compare May 7, 2025 19:13
@ndr-ds ndr-ds force-pushed the 04-30-use_networktopologystrategy_instead_of_simplestrategy branch 2 times, most recently from 6bfa2ed to 8ad0f96 Compare May 9, 2025 16:57
@ndr-ds ndr-ds force-pushed the 04-14-make_scylladb_replication_factor_configurable branch from 1971bcf to 2a07fcc Compare May 9, 2025 16:57
Copy link
Contributor Author

ndr-ds commented May 9, 2025

Merge activity

  • May 9, 5:25 PM EDT: A user started a stack merge that includes this pull request via Graphite.
  • May 9, 5:37 PM EDT: Graphite rebased this pull request as part of a merge.
  • May 9, 5:38 PM EDT: @ndr-ds merged this pull request with Graphite.

@ndr-ds ndr-ds changed the base branch from 04-14-make_scylladb_replication_factor_configurable to graphite-base/3880 May 9, 2025 21:34
@ndr-ds ndr-ds changed the base branch from graphite-base/3880 to main May 9, 2025 21:35
@ndr-ds ndr-ds force-pushed the 04-30-use_networktopologystrategy_instead_of_simplestrategy branch from 8ad0f96 to bf8f47e Compare May 9, 2025 21:37
@ndr-ds ndr-ds merged commit 4f081fe into main May 9, 2025
27 checks passed
@ndr-ds ndr-ds deleted the 04-30-use_networktopologystrategy_instead_of_simplestrategy branch May 9, 2025 21:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants