[FIRRTL] LowerSigs: Add enum support #8731
Open
+9
−1
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This adds support for enumerations to LowerSigs so that the pass no longer fails when it encounters an enum, and just passes them through unchanged.
|
(Fixes #7106 ? )
…On Thu, Jul 17, 2025, 5:30 PM Andrew Young ***@***.***> wrote:
This adds support for enumerations to LowerSigs so that the pass no longer
fails when it encounters an enum, and just passes them through unchanged.
------------------------------
You can view, comment on, or merge this pull request online at:
#8731
Commit Summary
- ece5537
<ece5537>
[FIRRTL] LowerSigs: Add enum support
File Changes
(2 files <https://github.com/llvm/circt/pull/8731/files>)
- *M* lib/Dialect/FIRRTL/Transforms/LowerSignatures.cpp
<https://github.com/llvm/circt/pull/8731/files#diff-0a6947a668c095ae65f13f1cee8dfab1fafedce0f2fa783a88ad678e3d99b715>
(1)
- *M* test/Dialect/FIRRTL/lower-types.mlir
<https://github.com/llvm/circt/pull/8731/files#diff-e241a91ad52bc4e9f6a08401046bf3e309bc391945dfccdbe69b9d8f97943950>
(9)
Patch Links:
- https://github.com/llvm/circt/pull/8731.patch
- https://github.com/llvm/circt/pull/8731.diff
—
Reply to this email directly, view it on GitHub
<#8731>, or unsubscribe
<https://github.com/notifications/unsubscribe-auth/AYZWN5M7AQXRACK75ANIKZD3JAPXFAVCNFSM6AAAAACBZCOR46VHI2DSMVQWIX3LMV43ASLTON2WKOZTGI2DCMJQG44TINA>
.
You are receiving this because you are subscribed to this thread.Message
ID: ***@***.***>
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This adds support for enumerations to LowerSigs so that the pass no longer fails when it encounters an enum, and just passes them through unchanged.