[-Wunsafe-buffer-usage] Do not warn about class methods with libc function names #151270
+72
−7
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ction names
This commit fixes the false positive that C++ class methods with libc
function names would be false warned about. For example,
```
struct T {void strcpy() const;};
void test(const T& t) { str.strcpy(); // no warn }
```
rdar://156264388
ziqingluo-90
requested review from
haoNoQ,
malavikasamak,
t-rasmud,
patrykstefanski and
jkorous-apple
llvmbot
added
clang
|
@llvm/pr-subscribers-clang Author: Ziqing Luo (ziqingluo-90) ChangesThis commit fixes the false positive that C++ class methods with libc function names would be false warned about. For example, rdar://156264388 Full diff: https://github.com/llvm/llvm-project/pull/151270.diff 2 Files Affected:
diff --git a/clang/lib/Analysis/UnsafeBufferUsage.cpp b/clang/lib/Analysis/UnsafeBufferUsage.cpp
index ac47b12cc8d72..6cd71c7674a92 100644
--- a/clang/lib/Analysis/UnsafeBufferUsage.cpp
+++ b/clang/lib/Analysis/UnsafeBufferUsage.cpp
@@ -1925,7 +1925,7 @@ class UnsafeLibcFunctionCallGadget : public WarningGadget {
if (!CE || !CE->getDirectCallee())
return false;
const auto *FD = dyn_cast<FunctionDecl>(CE->getDirectCallee());
- if (!FD)
+ if (!FD || isa<CXXMethodDecl>(FD))
return false;
auto isSingleStringLiteralArg = false;
if (CE->getNumArgs() == 1) {
diff --git a/clang/test/SemaCXX/warn-unsafe-buffer-usage-libc-functions.cpp b/clang/test/SemaCXX/warn-unsafe-buffer-usage-libc-functions.cpp
index d6c32ca7baa5d..e6902c5a95dc0 100644
--- a/clang/test/SemaCXX/warn-unsafe-buffer-usage-libc-functions.cpp
+++ b/clang/test/SemaCXX/warn-unsafe-buffer-usage-libc-functions.cpp
@@ -155,3 +155,21 @@ void ff(char * p, char * q, std::span<char> s, std::span<char> s2) {
wcscpy_s();
#pragma clang diagnostic pop
}
+
+
+namespace CXXMethodNoWarn {
+ struct StrBuff
+ {
+ void strcpy() const;
+ void strcpy(char* dst) const;
+ void Strcpy(char* dst) const;
+ };
+
+ void test(const StrBuff& str)
+ {
+ char buff[64];
+ str.strcpy();
+ str.strcpy(buff);
+ str.Strcpy(buff);
+ }
+} // namespace CXXMethodNoWarn
|
|
@llvm/pr-subscribers-clang-analysis Author: Ziqing Luo (ziqingluo-90) ChangesThis commit fixes the false positive that C++ class methods with libc function names would be false warned about. For example, rdar://156264388 Full diff: https://github.com/llvm/llvm-project/pull/151270.diff 2 Files Affected:
diff --git a/clang/lib/Analysis/UnsafeBufferUsage.cpp b/clang/lib/Analysis/UnsafeBufferUsage.cpp
index ac47b12cc8d72..6cd71c7674a92 100644
--- a/clang/lib/Analysis/UnsafeBufferUsage.cpp
+++ b/clang/lib/Analysis/UnsafeBufferUsage.cpp
@@ -1925,7 +1925,7 @@ class UnsafeLibcFunctionCallGadget : public WarningGadget {
if (!CE || !CE->getDirectCallee())
return false;
const auto *FD = dyn_cast<FunctionDecl>(CE->getDirectCallee());
- if (!FD)
+ if (!FD || isa<CXXMethodDecl>(FD))
return false;
auto isSingleStringLiteralArg = false;
if (CE->getNumArgs() == 1) {
diff --git a/clang/test/SemaCXX/warn-unsafe-buffer-usage-libc-functions.cpp b/clang/test/SemaCXX/warn-unsafe-buffer-usage-libc-functions.cpp
index d6c32ca7baa5d..e6902c5a95dc0 100644
--- a/clang/test/SemaCXX/warn-unsafe-buffer-usage-libc-functions.cpp
+++ b/clang/test/SemaCXX/warn-unsafe-buffer-usage-libc-functions.cpp
@@ -155,3 +155,21 @@ void ff(char * p, char * q, std::span<char> s, std::span<char> s2) {
wcscpy_s();
#pragma clang diagnostic pop
}
+
+
+namespace CXXMethodNoWarn {
+ struct StrBuff
+ {
+ void strcpy() const;
+ void strcpy(char* dst) const;
+ void Strcpy(char* dst) const;
+ };
+
+ void test(const StrBuff& str)
+ {
+ char buff[64];
+ str.strcpy();
+ str.strcpy(buff);
+ str.Strcpy(buff);
+ }
+} // namespace CXXMethodNoWarn
|
|
CC @dtarditi |
Xazax-hun
reviewed
Jul 30, 2025
|
I agree that we should probably check for the function being in the global scope or the |
Xazax-hun
approved these changes
Aug 1, 2025
|
LLVM Buildbot has detected a new failure on builder Full details are available at: https://lab.llvm.org/buildbot/#/builders/169/builds/13795 Here is the relevant piece of the build log for the reference |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This commit fixes the false positive that C++ class methods with libc function names would be false warned about. For example,
rdar://156264388