Skip to content

[-Wunsafe-buffer-usage] Do not warn about class methods with libc function names #151270

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 5 commits into from
Aug 7, 2025
Merged

[-Wunsafe-buffer-usage] Do not warn about class methods with libc function names #151270

Show file tree
Hide file tree
Changes from 2 commits
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
50ea604
[-Wunsafe-buffer-usage] Do not warn about class methods with libc fun…
ziqingluo-90 Jul 30, 2025
8c907cd
Merge branch 'main' into ziqing/PR-156264388
ziqingluo-90 Jul 30, 2025
b1b87fb
address comments
ziqingluo-90 Aug 1, 2025
851097f
Merge branch 'main' into ziqing/PR-156264388
ziqingluo-90 Aug 1, 2025
a187e19
Merge branch 'main' into ziqing/PR-156264388
ziqingluo-90 Aug 1, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion clang/lib/Analysis/UnsafeBufferUsage.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1925,7 +1925,7 @@ class UnsafeLibcFunctionCallGadget : public WarningGadget {
if (!CE || !CE->getDirectCallee())
return false;
const auto *FD = dyn_cast<FunctionDecl>(CE->getDirectCallee());
if (!FD)
if (!FD || isa<CXXMethodDecl>(FD))
return false;
auto isSingleStringLiteralArg = false;
if (CE->getNumArgs() == 1) {
Expand Down
18 changes: 18 additions & 0 deletions clang/test/SemaCXX/warn-unsafe-buffer-usage-libc-functions.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -155,3 +155,21 @@ void ff(char * p, char * q, std::span<char> s, std::span<char> s2) {
wcscpy_s();
#pragma clang diagnostic pop
}


namespace CXXMethodNoWarn {
struct StrBuff
{
void strcpy() const;
void strcpy(char* dst) const;
void Strcpy(char* dst) const;
};

void test(const StrBuff& str)
{
char buff[64];
str.strcpy();
str.strcpy(buff);
str.Strcpy(buff);
}
} // namespace CXXMethodNoWarn
Loading