Skip to content

[ARM] [IR] [Builtins] Give the data barrier instructions the same attributes they have in AArch64 #152415

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 2 commits into
base: main
Choose a base branch
from
Open
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 4 additions & 5 deletions llvm/include/llvm/IR/IntrinsicsARM.td
Original file line number Diff line number Diff line change
Expand Up @@ -299,13 +299,12 @@ def int_arm_ldaexd : Intrinsic<[llvm_i32_ty, llvm_i32_ty], [llvm_ptr_ty]>;
//===----------------------------------------------------------------------===//
// Data barrier instructions

// TODO: Add applicable default attributes.
def int_arm_dmb : ClangBuiltin<"__builtin_arm_dmb">, MSBuiltin<"__dmb">,
Intrinsic<[], [llvm_i32_ty]>;
Intrinsic<[], [llvm_i32_ty], [IntrNoFree, IntrWillReturn]>;
def int_arm_dsb : ClangBuiltin<"__builtin_arm_dsb">, MSBuiltin<"__dsb">,
Intrinsic<[], [llvm_i32_ty]>;
Intrinsic<[], [llvm_i32_ty], [IntrNoFree, IntrWillReturn]>;
def int_arm_isb : ClangBuiltin<"__builtin_arm_isb">, MSBuiltin<"__isb">,
Intrinsic<[], [llvm_i32_ty]>;
Intrinsic<[], [llvm_i32_ty], [IntrNoFree, IntrWillReturn]>;

//===----------------------------------------------------------------------===//
// VFP
Expand Down Expand Up @@ -410,8 +409,8 @@ def int_arm_cmse_ttat : ClangBuiltin<"__builtin_arm_cmse_TTAT">,
//===----------------------------------------------------------------------===//
// HINT

def int_arm_hint : DefaultAttrsIntrinsic<[], [llvm_i32_ty]>;
// TODO: Add applicable default attributes.
def int_arm_hint : Intrinsic<[], [llvm_i32_ty]>;
def int_arm_dbg : Intrinsic<[], [llvm_i32_ty]>;

//===----------------------------------------------------------------------===//
Expand Down