Skip to content

Conversation

MaticTonin
Copy link
Collaborator

Reason for that PR request is to test if the uploaded wheels to artifactory are correctly installed after each upload for all platforms.

Idea is to catch error like this one:
https://github.com/luxonis/depthai-core/actions/runs/17500499704/job/49713758148

Needed change would be to introduce the artifactory page IP as a secret (required, otherwise GitHub labeled it as untrusty page.

@lnotspotl lnotspotl added the testable PR is ready to be tested label Sep 23, 2025
@lnotspotl
Copy link
Member

lnotspotl commented Sep 24, 2025

I really like this, @MaticTonin, and once #1469 is merged in, this should start working.

Maybe this should also fail if other dependencies are not present? https://github.com/luxonis/depthai-core/actions/runs/17962117031/job/51091008085

image

Turns out this is an internal pybind11 error and even though it cannot find numpy, the python module itself still loads successfully.

@lnotspotl
Copy link
Member

I cherry-picked the commits from this PR, making their base the parent commit of 911f72c (the parent commit being 6168267). This commit introduced a fix to missing DLLs on Windows.

The proposed changes and tests designed by @MaticTonin successfully caught a bug concerning missing DDLs on Windows: https://github.com/luxonis/depthai-core/actions/runs/18115600581/job/51559083971

I think this is a nice starting point for wheel tests in the future. Should there be other issues with combined wheels, we can add other quick checks to the depthai_smoke script, thereby catching these bugs more quickly.

This PR is ready for another review, @moratom

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

testable PR is ready to be tested

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants