Merge main into develop so that workflows are picked up - #1937
Closed
aljazkonec1 wants to merge 9 commits into
Closed
Merge main into develop so that workflows are picked up#1937aljazkonec1 wants to merge 9 commits into
aljazkonec1 wants to merge 9 commits into
Conversation
…the functionality
Feature/hil testing overhaul
Contributor
📝 WalkthroughWalkthroughAdded scheduled, pull-request, nightly, and weekly HIL workflows. Updated the reusable test workflow with standard-test gating. Restricted pull-request workflow triggers and removed the previous test workflow. ChangesHIL workflow orchestration
Estimated code review effort: 4 (Complex) | ~45 minutes Sequence Diagram(s)sequenceDiagram
participant Scheduler
participant GitHubActions
participant ReusableTestWorkflow
participant ArtifactStore
participant Slack
Scheduler->>GitHubActions: dispatch nightly or weekly HIL workflow
GitHubActions->>ReusableTestWorkflow: run selected HIL test groups
ReusableTestWorkflow->>ArtifactStore: upload JUnit artifacts
GitHubActions->>ArtifactStore: download test artifacts
GitHubActions->>Slack: post test results and run details
Suggested reviewers: Poem
🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
✨ Finishing Touches 💡 1🛠️ Fix failing CI checks 💡
🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
Contributor
There was a problem hiding this comment.
Actionable comments posted: 1
🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
Inline comments:
In @.github/workflows/hil_testing_weekly.yml:
- Line 133: Update the workflow step using actions/download-artifact to
reference the immutable commit SHA d3f86a106a0bac45b974a628896c90dbdf5c8093
instead of the mutable v4 tag, preserving the step’s existing configuration.
🪄 Autofix
Fix all unresolved CodeRabbit comments on this PR:
- Push a commit to this branch (recommended)
- Create a new PR with the fixes
ℹ️ Review info
⚙️ Run configuration
Configuration used: Repository UI
Review profile: ASSERTIVE
Plan: Pro Plus
Run ID: 122652c8-a30f-4804-a09f-d6f06be6b9b4
📒 Files selected for processing (7)
.github/workflows/hil_testing_nightly.yml.github/workflows/hil_testing_pull_request.yml.github/workflows/hil_testing_schedule_develop.yml.github/workflows/hil_testing_weekly.yml.github/workflows/main.workflow.yml.github/workflows/test.workflow.yml.github/workflows/test_child.yml
💤 Files with no reviewable changes (1)
- .github/workflows/test.workflow.yml
📜 Review details
⏰ Context from checks skipped due to timeout. (5)
- GitHub Check: build-macos (3.11, macos-15-intel)
- GitHub Check: build-macos (3.12, macos-15-intel)
- GitHub Check: build-macos (3.9, macos-15-intel)
- GitHub Check: build-macos (3.10, macos-15-intel)
- GitHub Check: build-macos (3.13, macos-15-intel)
⚠️ CI failures not shown inline (13)
GitHub Actions: DepthAI Core CI/CD / 6_integration (macos-latest, Debug, true, x64).txt: Merge pull request #1934 from luxonis/feature/hil_testing_overhaul
Conclusion: failure
es/abseil_arm64-osx/lib/pkgconfig/absl_btree.pc
-- Fixing pkgconfig file: /Users/runner/work/depthai-core/depthai-core/build/vcpkg/packages/abseil_arm64-osx/lib/pkgconfig/absl_charset.pc
-- Fixing pkgconfig file: /Users/runner/work/depthai-core/depthai-core/build/vcpkg/packages/abseil_arm64-osx/lib/pkgconfig/absl_check.pc
-- Fixing pkgconfig file: /Users/runner/work/depthai-core/depthai-core/build/vcpkg/packages/abseil_arm64-osx/lib/pkgconfig/absl_city.pc
-- Fixing pkgconfig file: /Users/runner/work/depthai-core/depthai-core/build/vcpkg/packages/abseil_arm64-osx/lib/pkgconfig/absl_civil_time.pc
-- Fixing pkgconfig file: /Users/runner/work/depthai-core/depthai-core/build/vcpkg/packages/abseil_arm64-osx/lib/pkgconfig/absl_cleanup.pc
-- Fixing pkgconfig file: /Users/runner/work/depthai-core/depthai-core/build/vcpkg/packages/abseil_arm64-osx/lib/pkgconfig/absl_cleanup_internal.pc
-- Fixing pkgconfig file: /Users/runner/work/depthai-core/depthai-core/build/vcpkg/packages/abseil_arm64-osx/lib/pkgconfig/absl_common_policy_traits.pc
-- Fixing pkgconfig file: /Users/runner/work/depthai-core/depthai-core/build/vcpkg/packages/abseil_arm64-osx/lib/pkgconfig/absl_compare.pc
-- Fixing pkgconfig file: /Users/runner/work/depthai-core/depthai-core/build/vcpkg/packages/abseil_arm64-osx/lib/pkgconfig/absl_compressed_tuple.pc
-- Fixing pkgconfig file: /Users/runner/work/depthai-core/depthai-core/build/vcpkg/packages/abseil_arm64-osx/lib/pkgconfig/absl_config.pc
-- Fixing pkgconfig file: /Users/runner/work/depthai-core/depthai-core/build/vcpkg/packages/abseil_arm64-osx/lib/pkgconfig/absl_container_common.pc
-- Fixing pkgconfig file: /Users/runner/work/depthai-core/depthai-core/build/vcpkg/packages/abseil_arm64-osx/lib/pkgconfig/absl_container_memory.pc
-- Fixing pkgconfig file: /Users/runner/work/depthai-core/depthai-core/build/vcpkg/packages/abseil_arm64-osx/lib/pkgconfig/absl_cord.pc
-- Fixing pkgconfig file: /Users/runner/work/depthai-core/depthai-core/build/vcpkg/pa...
GitHub Actions: DepthAI Core CI/CD / 7_build (windows-2022, 3.22.x).txt: Merge pull request #1934 from luxonis/feature/hil_testing_overhaul
Conclusion: failure
re/depthai-core/build/vcpkg/downloads/bombela-backward-cpp-51f0700452cf71c57d43c2d028277b24cde32502.tar.gz
-- Using source at D:/a/depthai-core/depthai-core/build/vcpkg/buildtrees/backward-cpp/src/24cde32502-a757d548a3.clean
-- Found external ninja('1.12.1').
-- Configuring x64-windows
-- Building x64-windows-dbg
-- Building x64-windows-rel
-- Installing: D:/a/depthai-core/depthai-core/build/vcpkg/packages/backward-cpp_x64-windows/share/backward-cpp/copyright
-- Installing: D:/a/depthai-core/depthai-core/build/vcpkg/packages/backward-cpp_x64-windows/share/backward-cpp/usage
-- Performing post-build validation
Starting submission of backward-cpp:x64-windows@2023-11-24#1 to 1 binary cache(s) in the background
Elapsed time to handle backward-cpp:x64-windows: 8 s
backward-cpp:x64-windows package ABI: ***REDACTED_HIGH_ENTROPY_STRING***
Completed submission of yaml-cpp:x64-windows@0.8.0#3 to 1 binary cache(s) in 2.7 s
Installing 20/82 curl[core,non-http,schannel,ssl,sspi]:x64-windows@8.14.0...
Building curl[core,non-http,schannel,ssl,sspi]:x64-windows@8.14.0...
D:\a\depthai-core\depthai-core\cmake\triplets\x64-windows.cmake: info: loaded overlay triplet from here
C:\Users\runneradmin\AppData\Local\vcpkg\registries\git-trees\a6dd0b68e9a05ab5fb22973d7458aca29add3111: info: installing from git registry git+https://github.com/microsoft/vcpkg@a6dd0b68e9a05ab5fb22973d7458aca29add3111
Downloading https://github.com/curl/curl/archive/curl-8_14_0.tar.gz -> curl-curl-curl-8_14_0.tar.gz
Successfully downloaded curl-curl-curl-8_14_0.tar.gz
-- Extracting source D:/a/depthai-core/depthai-core/build/vcpkg/downloads/curl-curl-curl-8_14_0.tar.gz
-- Applying patch dependencies.patch
-- Applying patch pkgconfig-curl-config.patch
-- Using source at D:/a/depthai-core/depthai-core/build/vcpkg/buildtrees/curl/src/url-8_14_0-a154f65b74.clean
-- Using cached msys2-mingw-w64-x86_64-pkgconf-1~2.3.0-1-any.pkg.tar.zst
-- Using cached msys2-msys2-runtime-3.5.4-2-x86_64.pkg.t...
GitHub Actions: DepthAI Core CI/CD / 1_integration (windows-2022, Release, true, x64).txt: Merge pull request #1934 from luxonis/feature/hil_testing_overhaul
Conclusion: failure
oads/bombela-backward-cpp-51f0700452cf71c57d43c2d028277b24cde32502.tar.gz
-- Using source at D:/a/depthai-core/depthai-core/build/vcpkg/buildtrees/backward-cpp/src/24cde32502-a757d548a3.clean
-- Found external ninja('1.12.1').
-- Configuring x64-windows
-- Building x64-windows-dbg
-- Building x64-windows-rel
-- Installing: D:/a/depthai-core/depthai-core/build/vcpkg/packages/backward-cpp_x64-windows/share/backward-cpp/copyright
-- Installing: D:/a/depthai-core/depthai-core/build/vcpkg/packages/backward-cpp_x64-windows/share/backward-cpp/usage
-- Performing post-build validation
Starting submission of backward-cpp:x64-windows@2023-11-24#1 to 1 binary cache(s) in the background
Elapsed time to handle backward-cpp:x64-windows: 6.5 s
backward-cpp:x64-windows package ABI: ***REDACTED_HIGH_ENTROPY_STRING***
Completed submission of yaml-cpp:x64-windows@0.8.0#3 to 1 binary cache(s) in 2.1 s
Installing 20/81 curl[core,non-http,schannel,ssl,sspi]:x64-windows@8.14.0...
Building curl[core,non-http,schannel,ssl,sspi]:x64-windows@8.14.0...
D:\a\depthai-core\depthai-core\cmake\triplets\x64-windows.cmake: info: loaded overlay triplet from here
C:\Users\runneradmin\AppData\Local\vcpkg\registries\git-trees\a6dd0b68e9a05ab5fb22973d7458aca29add3111: info: installing from git registry git+https://github.com/microsoft/vcpkg@a6dd0b68e9a05ab5fb22973d7458aca29add3111
Downloading https://github.com/curl/curl/archive/curl-8_14_0.tar.gz -> curl-curl-curl-8_14_0.tar.gz
Successfully downloaded curl-curl-curl-8_14_0.tar.gz
-- Extracting source D:/a/depthai-core/depthai-core/build/vcpkg/downloads/curl-curl-curl-8_14_0.tar.gz
-- Applying patch dependencies.patch
-- Applying patch pkgconfig-curl-config.patch
-- Using source at D:/a/depthai-core/depthai-core/build/vcpkg/buildtrees/curl/src/url-8_14_0-a154f65b74.clean
-- Using cached msys2-mingw-w64-x86_64-pkgconf-1~2.3.0-1-any.pkg.tar.zst
-- Using cached msys2-msys2-runtime-3.5.4-2-x86_64.pkg.tar.zst
-- Using msys root at D...
GitHub Actions: DepthAI Core CI/CD / 2_build (macos-latest, 4.0.x).txt: Merge pull request #1934 from luxonis/feature/hil_testing_overhaul
Conclusion: failure
b.com/microsoft/vcpkg@a6dd0b68e9a05ab5fb22973d7458aca29add3111
Downloading https://github.com/curl/curl/archive/curl-8_14_0.tar.gz -> curl-curl-curl-8_14_0.tar.gz
Successfully downloaded curl-curl-curl-8_14_0.tar.gz
-- Extracting source /Users/runner/work/depthai-core/depthai-core/build/vcpkg/downloads/curl-curl-curl-8_14_0.tar.gz
-- Applying patch dependencies.patch
-- Applying patch pkgconfig-curl-config.patch
-- Using source at /Users/runner/work/depthai-core/depthai-core/build/vcpkg/buildtrees/curl/src/url-8_14_0-a154f65b74.clean
-- Found external ninja('1.13.2').
-- Configuring arm64-osx
-- Building arm64-osx-dbg
-- Building arm64-osx-rel
-- Fixing pkgconfig file: /Users/runner/work/depthai-core/depthai-core/build/vcpkg/packages/curl_arm64-osx/lib/pkgconfig/libcurl.pc
-- Fixing pkgconfig file: /Users/runner/work/depthai-core/depthai-core/build/vcpkg/packages/curl_arm64-osx/debug/lib/pkgconfig/libcurl.pc
-- Installing: /Users/runner/work/depthai-core/depthai-core/build/vcpkg/packages/curl_arm64-osx/share/curl/vcpkg-cmake-wrapper.cmake
-- Installing: /Users/runner/work/depthai-core/depthai-core/build/vcpkg/packages/curl_arm64-osx/share/curl/usage
-- Performing post-build validation
Starting submission of curl[core,non-http,sectransp,ssl]:arm64-osx@8.14.0 to 1 binary cache(s) in the background
Elapsed time to handle curl:arm64-osx: 46 s
curl:arm64-osx package ABI: ***REDACTED_HIGH_ENTROPY_STRING***
Completed submission of backward-cpp:arm64-osx@2023-11-24#1 to 1 binary cache(s) in 57 ms
Installing 23/84 cpr[core,ssl]:arm64-osx@1.11.0...
Building cpr[core,ssl]:arm64-osx@1.11.0...
/Users/runner/work/depthai-core/depthai-core/cmake/triplets/arm64-osx.cmake: info: loaded overlay triplet from here
/Users/runner/work/depthai-core/depthai-core/./cmake/ports/cpr: info: installing overlay port from here
Downloading https://github.com/libcpr/cpr/archive/1.11.0.tar.gz -> libcpr-cpr-1.11.0.tar.gz
Successfully downloaded libcpr-cpr-1.11.0.tar.gz
--...
GitHub Actions: DepthAI Core CI/CD / 3_integration (windows-2022, Debug, true, x64).txt: Merge pull request #1934 from luxonis/feature/hil_testing_overhaul
Conclusion: failure
ce D:/a/depthai-core/depthai-core/build/vcpkg/downloads/jbeder-yaml-cpp-0.8.0.tar.gz
-- Applying patch yaml-cpp-pr-1212.patch
-- Applying patch yaml-cpp-pr-1310.patch
-- Using source at D:/a/depthai-core/depthai-core/build/vcpkg/buildtrees/yaml-cpp/src/0.8.0-440b586ece.clean
-- Found external ninja('1.12.1').
-- Configuring x64-windows
-- Building x64-windows-dbg
-- Building x64-windows-rel
-- Fixing pkgconfig file: D:/a/depthai-core/depthai-core/build/vcpkg/packages/yaml-cpp_x64-windows/lib/pkgconfig/yaml-cpp.pc
-- Using cached msys2-mingw-w64-x86_64-pkgconf-1~2.3.0-1-any.pkg.tar.zst
-- Using cached msys2-msys2-runtime-3.5.4-2-x86_64.pkg.tar.zst
-- Using msys root at D:/a/depthai-core/depthai-core/build/vcpkg/downloads/tools/msys2/21caed2f81ec917b
-- Fixing pkgconfig file: D:/a/depthai-core/depthai-core/build/vcpkg/packages/yaml-cpp_x64-windows/debug/lib/pkgconfig/yaml-cpp.pc
-- Installing: D:/a/depthai-core/depthai-core/build/vcpkg/packages/yaml-cpp_x64-windows/share/yaml-cpp/copyright
-- Performing post-build validation
Starting submission of yaml-cpp:x64-windows@0.8.0#3 to 1 binary cache(s) in the background
Elapsed time to handle yaml-cpp:x64-windows: 21 s
yaml-cpp:x64-windows package ABI: ***REDACTED_HIGH_ENTROPY_STRING***
Completed submission of spdlog:x64-windows@1.15.3 to 1 binary cache(s) in 1.9 s
Installing 19/81 backward-cpp:x64-windows@2023-11-24#1...
Building backward-cpp:x64-windows@2023-11-24#1...
D:\a\depthai-core\depthai-core\cmake\triplets\x64-windows.cmake: info: loaded overlay triplet from here
C:\Users\runneradmin\AppData\Local\vcpkg\registries\git-trees\25c84663d7fe9c5010bfc7baf2ad7c1c70c5c429: info: installing from git registry git+https://github.com/microsoft/vcpkg@25c84663d7fe9c5010bfc7baf2ad7c1c70c5c429
Downloading https://github.com/bombela/backward-cpp/archive/51f0700452cf71c57d43c2d028277b24cde32502.tar.gz -> bombela-backward-cpp-51f0700452cf71c57d43c2d028277b24cde32502.tar.gz
Successfully downloaded bombela-b...
GitHub Actions: DepthAI Core CI/CD / 12_build (windows-2022, 4.0.x).txt: Merge pull request #1934 from luxonis/feature/hil_testing_overhaul
Conclusion: failure
ng from git registry git+https://github.com/microsoft/vcpkg@6bb28e97cced88426e3126a47e247ed65608cc86
Downloading https://github.com/abseil/abseil-cpp/archive/20250127.1.tar.gz -> abseil-abseil-cpp-20250127.1.tar.gz
Successfully downloaded abseil-abseil-cpp-20250127.1.tar.gz
-- Extracting source D:/a/depthai-core/depthai-core/build/vcpkg/downloads/abseil-abseil-cpp-20250127.1.tar.gz
-- Using source at D:/a/depthai-core/depthai-core/build/vcpkg/buildtrees/abseil/src/20250127.1-a0a219bf72.clean
-- Found external ninja('1.12.1').
-- Configuring x64-windows-dbg
-- Configuring x64-windows-rel
-- Building x64-windows-dbg
-- Building x64-windows-rel
-- Fixing pkgconfig file: D:/a/depthai-core/depthai-core/build/vcpkg/packages/abseil_x64-windows/lib/pkgconfig/absl_absl_check.pc
-- Fixing pkgconfig file: D:/a/depthai-core/depthai-core/build/vcpkg/packages/abseil_x64-windows/lib/pkgconfig/absl_absl_log.pc
-- Fixing pkgconfig file: D:/a/depthai-core/depthai-core/build/vcpkg/packages/abseil_x64-windows/lib/pkgconfig/absl_absl_vlog_is_on.pc
-- Fixing pkgconfig file: D:/a/depthai-core/depthai-core/build/vcpkg/packages/abseil_x64-windows/lib/pkgconfig/absl_algorithm.pc
-- Fixing pkgconfig file: D:/a/depthai-core/depthai-core/build/vcpkg/packages/abseil_x64-windows/lib/pkgconfig/absl_algorithm_container.pc
-- Fixing pkgconfig file: D:/a/depthai-core/depthai-core/build/vcpkg/packages/abseil_x64-windows/lib/pkgconfig/absl_any.pc
-- Fixing pkgconfig file: D:/a/depthai-core/depthai-core/build/vcpkg/packages/abseil_x64-windows/lib/pkgconfig/absl_any_invocable.pc
-- Fixing pkgconfig file: D:/a/depthai-core/depthai-core/build/vcpkg/packages/abseil_x64-windows/lib/pkgconfig/absl_atomic_hook.pc
-- Fixing pkgconfig file: D:/a/depthai-core/depthai-core/build/vcpkg/packages/abseil_x64-windows/lib/pkgconfig/absl_bad_any_cast.pc
-- Fixing pkgconfig file: D:/a/depthai-core/depthai-core/build/vcpkg/packages/abseil_x64-windows/lib/pkgconfig/absl_bad_any_cast_impl.pc
-- Fixing ...
GitHub Actions: DepthAI Core CI/CD / 5_integration (macos-latest, Release, true, x64).txt: Merge pull request #1934 from luxonis/feature/hil_testing_overhaul
Conclusion: failure
it-trees/6cdd95078ed4dc9bd700884cfc132dca24a99013: info: installing from git registry git+https://github.com/microsoft/vcpkg@6cdd95078ed4dc9bd700884cfc132dca24a99013
Downloading https://github.com/boostorg/mpl/archive/boost-1.88.0.tar.gz -> boostorg-mpl-boost-1.88.0.tar.gz
Successfully downloaded boostorg-mpl-boost-1.88.0.tar.gz
-- Extracting source /Users/runner/work/depthai-core/depthai-core/build/vcpkg/downloads/boostorg-mpl-boost-1.88.0.tar.gz
-- Applying patch fix-msvc-build.diff
-- Using source at /Users/runner/work/depthai-core/depthai-core/build/vcpkg/buildtrees/boost-mpl/src/ost-1.88.0-fa0ace56fe.clean
-- Found external ninja('1.13.2').
-- Configuring arm64-osx
-- Building arm64-osx-rel
-- Installing: /Users/runner/work/depthai-core/depthai-core/build/vcpkg/packages/boost-mpl_arm64-osx/share/boost-mpl/copyright
-- Performing post-build validation
Starting submission of boost-mpl:arm64-osx@1.88.0 to 1 binary cache(s) in the background
Elapsed time to handle boost-mpl:arm64-osx: 2.6 s
boost-mpl:arm64-osx package ABI: ***REDACTED_HIGH_ENTROPY_STRING***
Completed submission of boost-optional:arm64-osx@1.88.0 to 1 binary cache(s) in 10.7 ms
Installing 50/83 boost-typeof:arm64-osx@1.88.0...
Building boost-typeof:arm64-osx@1.88.0...
/Users/runner/work/depthai-core/depthai-core/cmake/triplets/arm64-osx.cmake: info: loaded overlay triplet from here
/Users/runner/.cache/vcpkg/registries/git-trees/75c8940f03c4002bb502d869a77288d59081d026: info: installing from git registry git+https://github.com/microsoft/vcpkg@75c8940f03c4002bb502d869a77288d59081d026
Downloading https://github.com/boostorg/typeof/archive/boost-1.88.0.tar.gz -> boostorg-typeof-boost-1.88.0.tar.gz
Successfully downloaded boostorg-typeof-boost-1.88.0.tar.gz
-- Extracting source /Users/runner/work/depthai-core/depthai-core/build/vcpkg/downloads/boostorg-typeof-boost-1.88.0.tar.gz
-- Using source at /Users/runner/work/depthai-core/depthai-core/build/vcpkg/buildtrees/boost-typeof/s...
GitHub Actions: DepthAI Core CI/CD / 9_integration (ubuntu-latest, Release, true, x64).txt: Merge pull request #1934 from luxonis/feature/hil_testing_overhaul
Conclusion: failure
cpkg/packages/abseil_x64-linux/debug/lib/pkgconfig/absl_stacktrace.pc
-- Fixing pkgconfig file: /home/runner/work/depthai-core/depthai-core/build/vcpkg/packages/abseil_x64-linux/debug/lib/pkgconfig/absl_status.pc
-- Fixing pkgconfig file: /home/runner/work/depthai-core/depthai-core/build/vcpkg/packages/abseil_x64-linux/debug/lib/pkgconfig/absl_statusor.pc
-- Fixing pkgconfig file: /home/runner/work/depthai-core/depthai-core/build/vcpkg/packages/abseil_x64-linux/debug/lib/pkgconfig/absl_str_format.pc
-- Fixing pkgconfig file: /home/runner/work/depthai-core/depthai-core/build/vcpkg/packages/abseil_x64-linux/debug/lib/pkgconfig/absl_str_format_internal.pc
-- Fixing pkgconfig file: /home/runner/work/depthai-core/depthai-core/build/vcpkg/packages/abseil_x64-linux/debug/lib/pkgconfig/absl_strerror.pc
-- Fixing pkgconfig file: /home/runner/work/depthai-core/depthai-core/build/vcpkg/packages/abseil_x64-linux/debug/lib/pkgconfig/absl_string_view.pc
-- Fixing pkgconfig file: /home/runner/work/depthai-core/depthai-core/build/vcpkg/packages/abseil_x64-linux/debug/lib/pkgconfig/absl_strings.pc
-- Fixing pkgconfig file: /home/runner/work/depthai-core/depthai-core/build/vcpkg/packages/abseil_x64-linux/debug/lib/pkgconfig/absl_strings_internal.pc
-- Fixing pkgconfig file: /home/runner/work/depthai-core/depthai-core/build/vcpkg/packages/abseil_x64-linux/debug/lib/pkgconfig/absl_symbolize.pc
-- Fixing pkgconfig file: /home/runner/work/depthai-core/depthai-core/build/vcpkg/packages/abseil_x64-linux/debug/lib/pkgconfig/absl_synchronization.pc
-- Fixing pkgconfig file: /home/runner/work/depthai-core/depthai-core/build/vcpkg/packages/abseil_x64-linux/debug/lib/pkgconfig/absl_throw_delegate.pc
-- Fixing pkgconfig file: /home/runner/work/depthai-core/depthai-core/build/vcpkg/packages/abseil_x64-linux/debug/lib/pkgconfig/absl_time.pc
-- Fixing pkgconfig file: /home/runner/work/depthai-core/depthai-core/build/vcpkg/packages/abseil_x64-linux/debug/lib/pkgconfig/absl_time_zone....
GitHub Actions: DepthAI Core CI/CD / 4_build (macos-latest, 3.22.x).txt: Merge pull request #1934 from luxonis/feature/hil_testing_overhaul
Conclusion: failure
ypeof:arm64-osx@1.88.0 to 1 binary cache(s) in the background
Elapsed time to handle boost-typeof:arm64-osx: 868 ms
boost-typeof:arm64-osx package ABI: ***REDACTED_HIGH_ENTROPY_STRING***
Completed submission of boost-mpl:arm64-osx@1.88.0 to 1 binary cache(s) in 115 ms
Installing 51/84 boost-tuple:arm64-osx@1.88.0...
Building boost-tuple:arm64-osx@1.88.0...
/Users/runner/work/depthai-core/depthai-core/cmake/triplets/arm64-osx.cmake: info: loaded overlay triplet from here
/Users/runner/.cache/vcpkg/registries/git-trees/55ab535f246ac9b26b4a76d5182fc593914bd691: info: installing from git registry git+https://github.com/microsoft/vcpkg@55ab535f246ac9b26b4a76d5182fc593914bd691
Downloading https://github.com/boostorg/tuple/archive/boost-1.88.0.tar.gz -> boostorg-tuple-boost-1.88.0.tar.gz
Successfully downloaded boostorg-tuple-boost-1.88.0.tar.gz
-- Extracting source /Users/runner/work/depthai-core/depthai-core/build/vcpkg/downloads/boostorg-tuple-boost-1.88.0.tar.gz
-- Using source at /Users/runner/work/depthai-core/depthai-core/build/vcpkg/buildtrees/boost-tuple/src/ost-1.88.0-1590de8f80.clean
-- Found external ninja('1.13.2').
-- Configuring arm64-osx
-- Building arm64-osx-rel
-- Installing: /Users/runner/work/depthai-core/depthai-core/build/vcpkg/packages/boost-tuple_arm64-osx/share/boost-tuple/copyright
-- Performing post-build validation
Starting submission of boost-tuple:arm64-osx@1.88.0 to 1 binary cache(s) in the background
Elapsed time to handle boost-tuple:arm64-osx: 791 ms
boost-tuple:arm64-osx package ABI: ***REDACTED_HIGH_ENTROPY_STRING***
Completed submission of boost-typeof:arm64-osx@1.88.0 to 1 binary cache(s) in 9.69 ms
Installing 52/84 boost-detail:arm64-osx@1.88.0...
Building boost-detail:arm64-osx@1.88.0...
/Users/runner/work/depthai-core/depthai-core/cmake/triplets/arm64-osx.cmake: info: loaded overlay triplet from here
/Users/runner/.cache/vcpkg/registries/git-trees/98a332b03b6cea4761f88e91583365d6541a363a: info: installing ...
GitHub Actions: DepthAI Core CI/CD / 8_integration (ubuntu-latest, Debug, true, x64).txt: Merge pull request #1934 from luxonis/feature/hil_testing_overhaul
Conclusion: failure
ts/cpr: info: installing overlay port from here
Downloading https://github.com/libcpr/cpr/archive/1.11.0.tar.gz -> libcpr-cpr-1.11.0.tar.gz
Successfully downloaded libcpr-cpr-1.11.0.tar.gz
-- Extracting source /home/runner/work/depthai-core/depthai-core/build/vcpkg/downloads/libcpr-cpr-1.11.0.tar.gz
-- Applying patch disable_werror.patch
-- Applying patch multi_cert.patch
-- Using source at /home/runner/work/depthai-core/depthai-core/build/vcpkg/buildtrees/cpr/src/1.11.0-c5369ac084.clean
-- Found external ninja('1.13.2').
-- Configuring x64-linux
-- Building x64-linux-dbg
-- Building x64-linux-rel
-- Installing: /home/runner/work/depthai-core/depthai-core/build/vcpkg/packages/cpr_x64-linux/share/cpr/copyright
-- Performing post-build validation
Starting submission of cpr[core,ssl]:x64-linux@1.11.0 to 1 binary cache(s) in the background
Elapsed time to handle cpr:x64-linux: 16 s
cpr:x64-linux package ABI: ***REDACTED_HIGH_ENTROPY_STRING***
Completed submission of curl[core,non-http,openssl,ssl]:x64-linux@8.14.0 to 1 binary cache(s) in 576 ms
Installing 26/83 abseil:x64-linux@20250127.1#1...
Building abseil:x64-linux@20250127.1#1...
/home/runner/work/depthai-core/depthai-core/cmake/triplets/x64-linux.cmake: info: loaded overlay triplet from here
/home/runner/.cache/vcpkg/registries/git-trees/6bb28e97cced88426e3126a47e247ed65608cc86: info: installing from git registry git+https://github.com/microsoft/vcpkg@6bb28e97cced88426e3126a47e247ed65608cc86
Downloading https://github.com/abseil/abseil-cpp/archive/20250127.1.tar.gz -> abseil-abseil-cpp-20250127.1.tar.gz
Successfully downloaded abseil-abseil-cpp-20250127.1.tar.gz
-- Extracting source /home/runner/work/depthai-core/depthai-core/build/vcpkg/downloads/abseil-abseil-cpp-20250127.1.tar.gz
-- Using source at /home/runner/work/depthai-core/depthai-core/build/vcpkg/buildtrees/abseil/src/20250127.1-a0a219bf72.clean
-- Found external ninja('1.13.2').
-- Configuring x64-linux-dbg
-- Configuring x...
GitHub Actions: DepthAI Core CI/CD / 11_build (ubuntu-latest, 3.22.x).txt: Merge pull request #1934 from luxonis/feature/hil_testing_overhaul
Conclusion: failure
st-1.88.0.tar.gz -> boostorg-move-boost-1.88.0.tar.gz
Successfully downloaded boostorg-move-boost-1.88.0.tar.gz
-- Extracting source /home/runner/work/depthai-core/depthai-core/build/vcpkg/downloads/boostorg-move-boost-1.88.0.tar.gz
-- Using source at /home/runner/work/depthai-core/depthai-core/build/vcpkg/buildtrees/boost-move/src/ost-1.88.0-d6f7db8579.clean
-- Found external ninja('1.13.2').
-- Configuring x64-linux
-- Building x64-linux-rel
-- Installing: /home/runner/work/depthai-core/depthai-core/build/vcpkg/packages/boost-move_x64-linux/share/boost-move/copyright
-- Performing post-build validation
Starting submission of boost-move:x64-linux@1.88.0 to 1 binary cache(s) in the background
Elapsed time to handle boost-move:x64-linux: 510 ms
boost-move:x64-linux package ABI: ***REDACTED_HIGH_ENTROPY_STRING***
Completed submission of boost-numeric-conversion:x64-linux@1.88.0 to 1 binary cache(s) in 7.12 ms
Installing 71/84 boost-intrusive:x64-linux@1.88.0...
Building boost-intrusive:x64-linux@1.88.0...
/home/runner/work/depthai-core/depthai-core/cmake/triplets/x64-linux.cmake: info: loaded overlay triplet from here
/home/runner/.cache/vcpkg/registries/git-trees/0e559d87a538a62ab92d14b3a1bf20f4b15e9801: info: installing from git registry git+https://github.com/microsoft/vcpkg@0e559d87a538a62ab92d14b3a1bf20f4b15e9801
Downloading https://github.com/boostorg/intrusive/archive/boost-1.88.0.tar.gz -> boostorg-intrusive-boost-1.88.0.tar.gz
Successfully downloaded boostorg-intrusive-boost-1.88.0.tar.gz
-- Extracting source /home/runner/work/depthai-core/depthai-core/build/vcpkg/downloads/boostorg-intrusive-boost-1.88.0.tar.gz
-- Using source at /home/runner/work/depthai-core/depthai-core/build/vcpkg/buildtrees/boost-intrusive/src/ost-1.88.0-2b4f794aaf.clean
-- Found external ninja('1.13.2').
-- Configuring x64-linux
-- Building x64-linux-rel
-- Installing: /home/runner/work/depthai-core/depthai-core/build/vcpkg/packages/boost-intrusive_x64-linux/...
GitHub Actions: DepthAI Core CI/CD / 10_build (ubuntu-latest, 4.0.x).txt: Merge pull request #1934 from luxonis/feature/hil_testing_overhaul
Conclusion: failure
865.clean
-- Found external ninja('1.13.2').
-- Configuring x64-linux
-- Building x64-linux-dbg
-- Building x64-linux-rel
-- Installing: /home/runner/work/depthai-core/depthai-core/build/vcpkg/packages/boost-container_x64-linux/share/boost-container/copyright
-- Performing post-build validation
Starting submission of boost-container:x64-linux@1.88.0 to 1 binary cache(s) in the background
Elapsed time to handle boost-container:x64-linux: 3 s
boost-container:x64-linux package ABI: ***REDACTED_HIGH_ENTROPY_STRING***
Completed submission of boost-intrusive:x64-linux@1.88.0 to 1 binary cache(s) in 38.1 ms
Installing 73/84 boost-lexical-cast:x64-linux@1.88.0...
Building boost-lexical-cast:x64-linux@1.88.0...
/home/runner/work/depthai-core/depthai-core/cmake/triplets/x64-linux.cmake: info: loaded overlay triplet from here
/home/runner/.cache/vcpkg/registries/git-trees/c3631cacb2113b407eaa8be643a96dae14464f79: info: installing from git registry git+https://github.com/microsoft/vcpkg@c3631cacb2113b407eaa8be643a96dae14464f79
Downloading https://github.com/boostorg/lexical_cast/archive/boost-1.88.0.tar.gz -> boostorg-lexical_cast-boost-1.88.0.tar.gz
Successfully downloaded boostorg-lexical_cast-boost-1.88.0.tar.gz
-- Extracting source /home/runner/work/depthai-core/depthai-core/build/vcpkg/downloads/boostorg-lexical_cast-boost-1.88.0.tar.gz
-- Using source at /home/runner/work/depthai-core/depthai-core/build/vcpkg/buildtrees/boost-lexical-cast/src/ost-1.88.0-d2336c6fb5.clean
-- Found external ninja('1.13.2').
-- Configuring x64-linux
-- Building x64-linux-rel
-- Installing: /home/runner/work/depthai-core/depthai-core/build/vcpkg/packages/boost-lexical-cast_x64-linux/share/boost-lexical-cast/copyright
-- Performing post-build validation
Starting submission of boost-lexical-cast:x64-linux@1.88.0 to 1 binary cache(s) in the background
Elapsed time to handle boost-lexical-cast:x64-linux: 762 ms
boost-lexical-cast:x64-linux package ABI: ***REDACTED_HIGH...
GitHub Actions: DepthAI Core CI/CD / 13_tidy.txt: Merge pull request #1934 from luxonis/feature/hil_testing_overhaul
Conclusion: failure
tor<std::vector<float>>& R);
| ^
| r
/home/runner/work/depthai-core/depthai-core/include/depthai/utility/matrixOps.hpp:46:81: warning: invalid case style for parameter 'R' [readability-identifier-naming]
46 | std::vector<float> matrix3x3ToVector(const std::array<std::array<float, 3>, 3>& R);
| ^
| r
/home/runner/work/depthai-core/depthai-core/include/depthai/utility/matrixOps.hpp:47:82: warning: invalid case style for parameter 'R' [readability-identifier-naming]
47 | std::vector<float> rotationMatrixToVector(const std::vector<std::vector<float>>& R);
| ^
| r
/home/runner/work/depthai-core/depthai-core/include/depthai/utility/matrixOps.hpp:48:100: warning: invalid case style for parameter 'R' [readability-identifier-naming]
48 | std::vector<std::vector<float>> matrix3x3ToVectorMatrix(const std::array<std::array<float, 3>, 3>& R);
| ^
| r
/home/runner/work/depthai-core/depthai-core/include/depthai/utility/matrixOps.hpp:49:100: warning: invalid case style for parameter 'R' [readability-identifier-naming]
49 | std::array<std::array<float, 3>, 3> vectorMatrixToMatrix3x3(const std::vector<std::vector<float>>& R);
| ^
| ...
🧰 Additional context used
🪛 zizmor (1.29.0)
.github/workflows/hil_testing_pull_request.yml
[warning] 58-58: code injection via template expansion (template-injection): may expand into attacker-controllable code
(template-injection)
[warning] 60-60: code injection via template expansion (template-injection): may expand into attacker-controllable code
(template-injection)
.github/workflows/hil_testing_schedule_develop.yml
[error] 9-9: overly broad permissions (excessive-permissions): actions: write is overly broad at the workflow level
(excessive-permissions)
[warning] 9-9: permissions without explanatory comments (undocumented-permissions): needs an explanatory comment
(undocumented-permissions)
[info] 12-12: workflow or action definition without a name (anonymous-definition): this job
(anonymous-definition)
[warning] 3-6: insufficient job-level concurrency limits (concurrency-limits): workflow is missing concurrency setting
(concurrency-limits)
.github/workflows/test_child.yml
[warning] 71-71: code injection via template expansion (template-injection): may expand into attacker-controllable code
(template-injection)
.github/workflows/hil_testing_weekly.yml
[warning] 35-35: code injection via template expansion (template-injection): may expand into attacker-controllable code
(template-injection)
[error] 133-133: unpinned action reference (unpinned-uses): action is not pinned to a hash (required by blanket policy)
(unpinned-uses)
[warning] 20-20: permissions without explanatory comments (undocumented-permissions): needs an explanatory comment
(undocumented-permissions)
[info] 29-29: workflow or action definition without a name (anonymous-definition): this job
(anonymous-definition)
[info] 120-120: workflow or action definition without a name (anonymous-definition): this job
(anonymous-definition)
🔇 Additional comments (6)
.github/workflows/test_child.yml (1)
20-23: LGTM!Also applies to: 71-71, 86-86, 114-114, 144-144, 170-170, 197-197, 253-253, 277-277
.github/workflows/hil_testing_nightly.yml (1)
1-28: LGTM!.github/workflows/hil_testing_pull_request.yml (1)
1-62: LGTM!.github/workflows/main.workflow.yml (1)
20-20: LGTM!.github/workflows/hil_testing_weekly.yml (1)
1-132: LGTM!Also applies to: 134-228
.github/workflows/hil_testing_schedule_develop.yml (1)
1-45: LGTM!
| runs-on: ubuntu-latest | ||
| steps: | ||
| - name: Download JUnit reports | ||
| uses: actions/download-artifact@v4 |
Contributor
There was a problem hiding this comment.
🔒 Security & Privacy | 🟠 Major | ⚡ Quick win
🧩 Analysis chain
🏁 Script executed:
#!/usr/bin/env bash
set -euo pipefail
# Inspect the current v4 reference before selecting an approved immutable SHA.
git ls-remote https://github.com/actions/download-artifact refs/tags/v4Repository: luxonis/depthai-core
Length of output: 212
🏁 Script executed:
#!/usr/bin/env bash
set -euo pipefail
# Resolve the v4 tag and verify that the resolved object is a commit.
git ls-remote \
https://github.com/actions/download-artifact \
refs/tags/v4 \
'refs/tags/v4^{}'
# Confirm the candidate SHA is a real commit.
curl --fail --silent --show-error \
-H 'Accept: application/vnd.github+json' \
https://api.github.com/repos/actions/download-artifact/commits/d3f86a106a0bac45b974a628896c90dbdf5c8093 \
| jq -r '.sha'Repository: luxonis/depthai-core
Length of output: 263
🏁 Script executed:
#!/usr/bin/env bash
set -euo pipefail
if command -v gh >/dev/null 2>&1; then
gh api repos/actions/download-artifact/commits/d3f86a106a0bac45b974a628896c90dbdf5c8093 \
--jq '.sha'
else
echo "gh CLI is unavailable"
fiRepository: luxonis/depthai-core
Length of output: 199
Pin actions/download-artifact to an immutable commit SHA.
Replace actions/download-artifact@v4 with actions/download-artifact@d3f86a106a0bac45b974a628896c90dbdf5c8093.
🧰 Tools
🪛 zizmor (1.29.0)
[error] 133-133: unpinned action reference (unpinned-uses): action is not pinned to a hash (required by blanket policy)
(unpinned-uses)
🤖 Prompt for AI Agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
In @.github/workflows/hil_testing_weekly.yml at line 133, Update the workflow
step using actions/download-artifact to reference the immutable commit SHA
d3f86a106a0bac45b974a628896c90dbdf5c8093 instead of the mutable v4 tag,
preserving the step’s existing configuration.
Source: Linters/SAST tools
Closed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Purpose
Specification
None / not applicable
Dependencies & Potential Impact
None / not applicable
Deployment Plan
None / not applicable
Testing & Validation
None / not applicable
AI Usage
Assisted-by: AGENT_NAME:MODEL_VERSION [TOOL1] [TOOL2]
Submitted code was reviewed by a human: YES/NO
The author is taking the responsibility for the contribution: YES/NO
Summary by CodeRabbit
New Features
Bug Fixes