Skip to content

Conversation

haarg
Copy link
Member

@haarg haarg commented Aug 11, 2025

The find_pod method would sometimes return the source and sometimes a full record from Elasticsearch. Fix the return to always return the source, and adjust the caller to work with this form.

mickeyn
mickeyn previously approved these changes Aug 11, 2025
Copy link

codecov bot commented Aug 11, 2025

Codecov Report

❌ Patch coverage is 66.66667% with 1 line in your changes missing coverage. Please review.
✅ Project coverage is 59.74%. Comparing base (ac26b19) to head (fdc134b).
⚠️ Report is 3 commits behind head on master.

Files with missing lines Patch % Lines
lib/MetaCPAN/Server/Model/Source.pm 0.00% 0 Missing and 1 partial ⚠️
Additional details and impacted files
@@           Coverage Diff           @@
##           master    #1386   +/-   ##
=======================================
  Coverage   59.74%   59.74%           
=======================================
  Files         135      135           
  Lines        4399     4399           
  Branches      671      671           
=======================================
  Hits         2628     2628           
  Misses       1517     1517           
  Partials      254      254           
Files with missing lines Coverage Δ
lib/MetaCPAN/Query/File.pm 76.31% <100.00%> (ø)
lib/MetaCPAN/Server/Controller/Pod.pm 68.18% <100.00%> (ø)
lib/MetaCPAN/Server/Model/Source.pm 59.01% <0.00%> (ø)
🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

The find_pod method would sometimes return the source and sometimes a
full record from Elasticsearch. Fix the return to always return the
source, and adjust the caller to work with this form.
@haarg haarg force-pushed the haarg/fix-pod-endpoint branch from 3208468 to fdc134b Compare August 11, 2025 21:22
@haarg haarg merged commit 44202f7 into master Aug 17, 2025
5 checks passed
@haarg haarg deleted the haarg/fix-pod-endpoint branch August 17, 2025 15:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants