Skip to content

fix the pod end point when given a module name #1386

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Aug 17, 2025
Merged

fix the pod end point when given a module name #1386

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
8033be9
better comment for source 404
haarg Aug 11, 2025
fdc134b
fix the pod end point when given a module name
haarg Aug 11, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion lib/MetaCPAN/Query/File.pm
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -679,7 +679,7 @@ sub find_pod {
query => $query,
},
);
return $pod_file->{hits}{hits}[0];
return $pod_file->{hits}{hits}[0]->{_source};
}
else {
return $file;
Expand Down
3 changes: 1 addition & 2 deletions lib/MetaCPAN/Server/Controller/Pod.pm
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -38,8 +38,7 @@ sub get : Path('') : Args(1) {
my ( $self, $c, $module ) = @_;
$module = $c->model('ESQuery')->file->find_pod($module)
or $c->detach( '/not_found', [] );
$c->forward( 'find',
[ map { $module->{_source}{$_} } qw(author release path) ] );
$c->forward( 'find', [ map { $module->{$_} } qw(author release path) ] );
}

sub find_dist_links {
Expand Down
5 changes: 4 additions & 1 deletion lib/MetaCPAN/Server/Model/Source.pm
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -87,8 +87,11 @@ sub path {
my $source = $source_base->child( $distvname, @file );
return $source
if -e $source;

# if the directory exists, we already extracted the archive, so if the
# file didn't exist, we can stop here
return undef
if -e $source_base->child($distvname); # previously extracted, but file does not exist
if -e $source_base->child($distvname);

my $release_data
= $self->es_query->release->by_author_and_name( $pauseid, $distvname )
Expand Down