Skip to content

DeployTo setting supported as environment variable #1702

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 82 commits into
base: main
Choose a base branch
from

Conversation

spetersenms
Copy link
Contributor

With this change, it is now possible to define your DeployTo setting as an environment variable in your GitHub environments.

@Copilot Copilot AI review requested due to automatic review settings May 5, 2025 09:29
@spetersenms spetersenms requested a review from a team as a code owner May 5, 2025 09:29
Copy link
Contributor

@Copilot Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR enables the use of environment variables for the DeployTo setting in GitHub environments. The key changes include:

  • Adding new workflow inputs (environmentName and environmentDeployToVariableValue) in multiple YAML workflow files.
  • Updating the ReadSettings action to pass the new inputs to the underlying PowerShell script.
  • Extending the existing workflows to support external configuration through environment variables.

Reviewed Changes

Copilot reviewed 4 out of 7 changed files in this pull request and generated no comments.

File Description
Templates/Per Tenant Extension/.github/workflows/PublishToEnvironment.yaml Added environment variable parameters to support DeployTo settings
Templates/Per Tenant Extension/.github/workflows/CICD.yaml Added environment variable parameters to support DeployTo settings
Templates/AppSource App/.github/workflows/CICD.yaml Added environment variable parameters to support DeployTo settings
Actions/ReadSettings/action.yaml Updated action inputs and run command to handle new environment variable settings
Files not reviewed (3)
  • Actions/AL-Go-Helper.ps1: Language not supported
  • Actions/ReadSettings/ReadSettings.ps1: Language not supported
  • Templates/AppSource App/.github/workflows/PublishToEnvironment.yaml: Language not supported
Comments suppressed due to low confidence (4)

Templates/Per Tenant Extension/.github/workflows/PublishToEnvironment.yaml:149

  • [nitpick] Consider renaming 'environmentDeployToVariableValue' to a more concise name (e.g., 'deployToVar') to improve clarity and reduce verbosity.
environmentDeployToVariableValue: ${{ vars.DeployTo }}

Templates/Per Tenant Extension/.github/workflows/CICD.yaml:287

  • [nitpick] Consider adopting a shorter name for 'environmentDeployToVariableValue' for consistency and better readability across workflow files.
environmentDeployToVariableValue: ${{ vars.DeployTo }}

Templates/AppSource App/.github/workflows/CICD.yaml:273

  • [nitpick] Consider using a shorter, more concise name for 'environmentDeployToVariableValue' for improved maintainability and consistency.
environmentDeployToVariableValue: ${{ vars.DeployTo }}

Actions/ReadSettings/action.yaml:24

  • [nitpick] Consider renaming the 'environmentDeployToVariableValue' input to a shorter name (e.g., 'deployToVar') to enhance clarity and consistency with other workflow files.
environmentDeployToVariableValue:

@spetersenms spetersenms marked this pull request as draft May 6, 2025 16:37
Copy link
Collaborator

@mazhelez mazhelez left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks okay, but more attention is needed.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants