-
Notifications
You must be signed in to change notification settings - Fork 150
DeployTo setting supported as environment variable #1702
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
spetersenms
wants to merge
82
commits into
microsoft:main
Choose a base branch
from
spetersenms:DeployToEnvVar
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Changes from 11 commits
Commits
Show all changes
82 commits
Select commit
Hold shift + click to select a range
32b0ee6
Added env params to ReadSettings and logic to get DeployTo var from e…
spetersenms c26f52a
Added environmentName and environmentDeployToVariable value parms.
spetersenms 27a2ab9
Added environmentName and environmentDeployToVariableValue params.
spetersenms a41820a
Passing new ReadSetting params in flows
spetersenms f5674c4
Precommit
spetersenms 8df75d4
Adding token to ReadSettings action and passing to ReadSettings helper.
spetersenms 23e0da8
Helper function to find deployment environment variables.
spetersenms 053361f
Moving read deployment environment variable logic to DetermineDeploym…
spetersenms 9647bf0
Merging DeployTo from settings file and env variable
spetersenms b0d2b95
Error handling
spetersenms 401230d
Using ghTokenWorkflow for authenticating the variables api endpoint.
spetersenms 3177598
Debug logs.
spetersenms afa11ce
Additional permissions for GITHUB_TOKEN
spetersenms e4f695f
Removed incorrect permission again.
spetersenms 3a87b7b
Requesting needed permissions for api.
spetersenms 3647d97
Updating permission param type to hashtable
spetersenms df0e312
Converting returned variable value from Json
spetersenms 286680c
Converting to hashtable
spetersenms 1599529
Removing debug logs
spetersenms dacf58b
Documentation updated.
spetersenms 0728f17
Adjust deployment environment variable setting to take priority over …
spetersenms f6b5a31
Adding new param to app source yaml to match PTE flow.
spetersenms ba01203
pre-commit
spetersenms 68fa02f
Mock variables api
spetersenms fa79500
Move url generation to try-catch for better error handling.
spetersenms 449e009
Setting default value for ghTokenWorkflow to empty string.
spetersenms ff2175d
Adding test to verify that deployment environment variable takes prio…
spetersenms 0f1fdde
Merge branch 'main' into DeployToEnvVar
spetersenms ed9c0aa
Merge branch 'DeployToEnvVar' of github.com:spetersenms/AL-Go into De…
spetersenms 58f5538
Fixing missing variable in test.
spetersenms 5f6d4b4
Passing ghTokenWorkflow to helper function.
spetersenms 198e2b5
Debug comment removed.
spetersenms bbf6c54
Reverting changes to Init job.
spetersenms 4332e5c
Printing warning if unsupported property is used in environment varia…
spetersenms dca4389
Reverting functionality to original state.
spetersenms 1cc7766
Removed incorrect whitespace.
spetersenms aa2e709
Merge branch 'main' into DeployToEnvVar
spetersenms f59d583
Added back param accidentally removed while fixing conflict from merg…
spetersenms 8998640
Reverting test changes.
spetersenms b0ba1f1
Added release notes.
spetersenms ae59ef9
Merge branch 'main' into DeployToEnvVar
spetersenms c166955
Merge branch 'main' into DeployToEnvVar
spetersenms fd1b9a4
Moved release notes.
spetersenms efbccd7
Merge branch 'main' into DeployToEnvVar
spetersenms c8aa5d1
Merge branch 'main' into DeployToEnvVar
spetersenms 512eaf8
Merge branch 'main' into DeployToEnvVar
spetersenms e9cc5cd
Merge branch 'main' into DeployToEnvVar
spetersenms 937cd81
Merge branch 'main' into DeployToEnvVar
spetersenms aeea15e
Readding logic accidentally removed during merge from main conflict h…
spetersenms e155e85
Using more generic name for environment settings, and testing use of …
spetersenms f5058b3
Moving env to step
spetersenms 4349eaf
Trying to set env vars in new step.
spetersenms 0cdd7a1
Corrected syntax.
spetersenms 2e2b4fc
Compressing json.
spetersenms 9b27b42
Forcing string type.
spetersenms 055fd42
Single quotes instead of double
spetersenms 0b38ecd
Using env variables instead of passing param.
spetersenms 0eeec84
Removing all param passing of repo env variable and use passing as en…
spetersenms 2dafad6
Merge branch 'main' into DeployToEnvVar
spetersenms 4d94f33
Consistency across workflows.
spetersenms 138fc2e
Aligning format of environment settings to be similar to org and repo…
spetersenms bfaf06f
Merge branch 'DeployToEnvVar' of github.com:spetersenms/AL-Go into De…
spetersenms a5649f6
Better formatting of warning.
spetersenms b63b47e
Typo.
spetersenms 09c82fc
Using ALGoEnvironmentSettings instead of DeployTo for env setting var…
spetersenms af5af45
Removing debug comment.
spetersenms eb205b3
pre-commit
spetersenms c6323d7
Updated action readme.
spetersenms 257ed70
Updated release notes.
spetersenms c982d24
pre-commit
spetersenms 0cf6585
Fixed function documentation error.
spetersenms 2376f12
Merge branch 'main' into DeployToEnvVar
spetersenms 7cbf9a9
Adjusted release notes to fit more generic implementation.
spetersenms 90fa6fb
Using OutputWarning.
spetersenms 46b2b50
Merge branch 'DeployToEnvVar' of github.com:spetersenms/AL-Go into De…
spetersenms dc3dcce
Merge branch 'main' into DeployToEnvVar
spetersenms 7eabca3
Using job env to set repo env var value
spetersenms efcaea2
Removed warning.
spetersenms 3725574
Merge branch 'main' into DeployToEnvVar
spetersenms c74046d
Aligning workflows.
spetersenms 8716c6e
Merge branch 'DeployToEnvVar' of github.com:spetersenms/AL-Go into De…
spetersenms 3a5d393
Merge branch 'main' into DeployToEnvVar
spetersenms File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -1347,4 +1347,4 @@ function Invoke-CommandWithRetry { | |
} | ||
} | ||
} | ||
} | ||
} |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.