More localization fixes for OpenFolderSchema.json - #1517
Merged
Gregg Miskelly (gregg-miskelly) merged 2 commits intoSep 4, 2025
Merged
Conversation
This PR checks in fixes from using lcxadmin.exe to further edit OpenFolderSchema.json.lci. This also deletes a .lsproj and .lcg file which were checked in, but I believe should not have been as these are generated from the build. Notes on how to do this in the future: 1. First, we need to add MicroBuild.Plugins.Localization to the local nuget cache . I was able to do so thusly: `nuget install MicroBuild.Plugins.Localization -Source "https://pkgs.dev.azure.com/devdiv/_packaging/MicroBuildToolset/nuget/v3/index.json" -Prerelease -OutputDirectory test`. After running this, you should be able to remove the `test` directory since the pluggin should now be in your nuget cache. 2. Next I built in `src\MIDebugPackage` using `msbuild /p:LocType=Pseudo /p:LocLanguages=VS /p:LSBuildVersion=V7 /p:LocalizationEnabled=true`. I first build the repo from VS so that any dependencies would be found. 3. I then used `NugetPackages\microsoft.devdiv.localization.toolset\1.1.24090301\current\lcxadmin.exe MIEngine\bin\Debug\localize\ENU\OpenFolderSchema.json.lcg MIEngine\loc\lci\OpenFolderSchema.json.lci` to open the LCI editor, and configured strings. 4. Repeat building 5. Use `"C:\Program Files\Git\usr\bin\diff.exe" d:\dd\MIEngine\bin\Debug\OpenFolderSchema.json d:\dd\MIEngine\bin\Debug\localize\CHS\OpenFolderSchema.json | findstr /v /c:"description"` to see if any non-description lines are being changed between ENU and the localized version.
Gregg Miskelly (gregg-miskelly)
requested a review
from Andrew Wang (WardenGnaw)
September 4, 2025 21:38
Andrew Wang (WardenGnaw)
approved these changes
Sep 4, 2025
Gregg Miskelly (gregg-miskelly)
merged commit Sep 4, 2025
7c35656
into
microsoft:main
6 checks passed
Gregg Miskelly (gregg-miskelly)
deleted the
OpenFolderSchemaLocFixesV2
branch
September 4, 2025 22:43
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR checks in fixes from using lcxadmin.exe to further edit OpenFolderSchema.json.lci. This also deletes a .lsproj and .lcg file which were checked in, but I believe should not have been as these are generated from the build.
Notes on how to do this in the future:
nuget install MicroBuild.Plugins.Localization -Source "https://pkgs.dev.azure.com/devdiv/_packaging/MicroBuildToolset/nuget/v3/index.json" -Prerelease -OutputDirectory test. After running this, you should be able to remove thetestdirectory since the plugin should now be in your nuget cache.src\MIDebugPackage, build usingmsbuild /p:LocType=Pseudo /p:LocLanguages=VS /p:LSBuildVersion=V7 /p:LocalizationEnabled=true.NugetPackages\microsoft.devdiv.localization.toolset\1.1.24090301\current\lcxadmin.exe MIEngine\bin\Debug\localize\ENU\OpenFolderSchema.json.lcg MIEngine\loc\lci\OpenFolderSchema.json.lcito open the LCI editor, and configured strings."C:\Program Files\Git\usr\bin\diff.exe" d:\dd\MIEngine\bin\Debug\OpenFolderSchema.json d:\dd\MIEngine\bin\Debug\localize\CHS\OpenFolderSchema.json | findstr /v /c:"description"to see if any non-description lines are being changed between ENU and the localized version.