Skip to content

Conversation

@MoritzTSR
Copy link

The Get-BcNuGetPackageId function causes an issue when working with the DynamicsBCPublicFeeds for AppSource Symbols.

Although the maximum allowed length for a NuGet Package ID is 100 characters, the function currently truncates the ID to 99 characters. This leads to a mismatch with the actual package IDs published in the AppSourceSymbols feed, which use the full 100-character length.

Example

1. Original TRASERSoftwareGmbH.TRASERECMConnect365xShareflexDocuments.symbols.c909c76e-7140-4e34-ba8e-7b47a8fe0247 (101 characters)
2. Output from Get-BcNuGetPackageId TRASERSoftwareGmbH.TRASERECMConnect365xShareflexDocume.symbols.c909c76e-7140-4e34-ba8e-7b47a8fe0247 (99 characters)
3. Actual in AppSourceSymbols TRASERSoftwareGmbH.TRASERECMConnect365xShareflexDocumen.symbols.c909c76e-7140-4e34-ba8e-7b47a8fe0247 (100 characters)

Impact

This one-character mismatch leads to failed package resolution with the Feed.

DynamicsBCPublicFeeds: https://dynamicssmb2.visualstudio.com/DynamicsBCPublicFeeds/_artifacts/feed/AppSourceSymbols

@MoritzTSR MoritzTSR requested a review from a team as a code owner June 17, 2025 15:09
mazhelez
mazhelez previously approved these changes Jul 4, 2025
Copy link
Collaborator

@mazhelez mazhelez left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you also please add release notes

@MoritzTSR MoritzTSR force-pushed the fix-nuget-packet-id-shortening branch from 779d03b to 62d8729 Compare July 24, 2025 07:21
@MoritzTSR
Copy link
Author

@microsoft-github-policy-service agree company="TRASER Software GmbH"

mazhelez
mazhelez previously approved these changes Aug 29, 2025
@mazhelez
Copy link
Collaborator

mazhelez commented Sep 2, 2025

Hey @MoritzTSR

Thanks a lot for taking the time to contribute to BCContainerHelper!
After getting a closer look by the BCContainerHelper team, it looks like your change to Get-BcNuGetPackageId is breaking for the existing packages.
E.g. packages' names that are created via Get-BcNuGetPackageId might be trimmed down to 99 characters and, if we accept your change, these packages will not be found anymore.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants