Skip to content

Fix package ID length adjustment logic in Get-BcNuGetPackageId function #3966

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 3 commits into
base: main
Choose a base branch
from
+3 −2
Open

Fix package ID length adjustment logic in Get-BcNuGetPackageId function #3966

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
62d8729
Fix package ID length adjustment logic in Get-BcNuGetPackageId function
MoritzTSR Jun 17, 2025
77bb926
Update ReleaseNotes to include fix for package ID length adjustment i…
MoritzTSR Jul 24, 2025
0e67397
Merge branch 'main' into fix-nuget-packet-id-shortening
MoritzTSR Sep 1, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions NuGet/Get-BcNuGetPackageId.ps1
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -49,8 +49,8 @@ function Get-BcNuGetPackageId {
# Max. Length of NuGet Package Id is 100 - we shorten the name part of the id if it is too long
$packageId = $packageIdTemplate.replace('{name}',$nname)
if ($packageId.Length -gt 100) {
if ($nname.Length -gt ($packageId.Length - 99)) {
$nname = $nname.Substring(0, $nname.Length - ($packageId.Length - 99))
if ($nname.Length -gt ($packageId.Length - 100)) {
$nname = $nname.Substring(0, $nname.Length - ($packageId.Length - 100))
}
else {
throw "Package id is too long: $packageId, unable to shorten it"
Expand Down
1 change: 1 addition & 0 deletions ReleaseNotes.txt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -6,6 +6,7 @@ Issue 3952 Get-AlLanguageExtensionFromArtifacts fails on new BC artifacts
Add support for TestType field when running tests
Issue 3943 Error downloading symbols for Microsoft_System
Add support for RequiredTestIsolation field when running tests
Fix package ID length adjustment logic in Get-BcNuGetPackageId function
Catch errors when page scripting tests are failing

6.1.6
Expand Down